Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Expressions to generate InvokeDelegate #5298

Merged

Conversation

g7ed6e
Copy link
Contributor

@g7ed6e g7ed6e commented Sep 26, 2023

Use Expressions to generate InvokeDelegate. This is a performance improvement which will make callback dispatch slight faster by removing MethodInfo.Invoke calls and using LINQ expressions to compile a delegate which is strongly typed.

@g7ed6e
Copy link
Contributor Author

g7ed6e commented Sep 26, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 5298 in repo dotnet/wcf

@mconnew
Copy link
Member

mconnew commented Oct 3, 2023

We should document the AppContext switch System.ServiceModel.Dispatcher.UseLegacyInvokeDelegate that it reverts to the old behavior in case there's an unforeseen compatibility issue.

@HongGit HongGit merged commit c6a30aa into dotnet:main Oct 3, 2023
8 checks passed
HongGit added a commit that referenced this pull request Nov 14, 2023
* Add 6.2 release notes

* Unix domain socket binding on WCF Client

* review comments

* incorporated review comments

* Incorporated the feedback for socket connection

* Use Expressions to generate InvokeDelegate (#5298)

* Use Expressions to generate InvokeDelegate

* Remove unnecessary cast

* Port Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory m… (#5343)

* Port Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory models

* Remove dotnet-blob-feed

* Catch unhandled exception when closing connection. (#5342)

* prepare main branch to be 6.2 branding (#5309)

* prepare WCF Client 6.2 GA release (#5346)

* Localized file check-in by OneLocBuild Task: Build definition ID 318: Build ID 2303041 (#5336)

---------

Co-authored-by: Biroj Nayak <49173255+birojnayak@users.noreply.github.com>
Co-authored-by: Biroj Nayak <biroj@amazon.com>
Co-authored-by: Guillaume Delahaye <681739+g7ed6e@users.noreply.github.com>
Co-authored-by: Carol Wang <v-carwan@microsoft.com>
Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants