Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support net8 SDK in dotnet-svcutil #5376

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Support net8 SDK in dotnet-svcutil #5376

merged 1 commit into from
Dec 14, 2023

Conversation

betmix-matt
Copy link
Contributor

Resolves Issue #5362

@betmix-matt
Copy link
Contributor Author

If we can get this merged before the 2.2 release, it can include both .NET 7 and .NET 8 support for dotnet-svcutil

@betmix-matt betmix-matt mentioned this pull request Dec 12, 2023
Open
@HongGit HongGit requested a review from imcarolwang December 12, 2023 22:20
imcarolwang
imcarolwang approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@imcarolwang imcarolwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HongGit HongGit merged commit b179144 into dotnet:main Dec 14, 2023
8 checks passed
@0xced
Copy link
Contributor

0xced commented Dec 14, 2023

I think the dotnet-svcutil tool should be configured to roll forward to the latest major .NET version, just like the dotnet ef tool did.

Basically, that means adding the <RollForward>Major</RollForward> property in the project file.

So that when new runtimes are released the tool will automatically work with the new runtime. There's even a proposal for this behavior to be the default for .NET tools (dotnet/sdk#30336) but it has not been implemented yet.

@imcarolwang imcarolwang mentioned this pull request Jan 11, 2024
Open
organich pushed a commit to organich/wcf that referenced this pull request Aug 31, 2024
@betmix-matt @organich
Support net8 SDK in dotnet-svcutil (dotnet#5376)
994f100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imcarolwang imcarolwang imcarolwang approved these changes

@HongGit HongGit HongGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betmix-matt @0xced @HongGit @imcarolwang