-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet-svcutil: write generated json file with relative path for referenced assembly. #5500
Open
imcarolwang
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
imcarolwang:issue5495
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any estimations for the merge? ;-) |
imcarolwang
commented
Sep 6, 2024
imcarolwang
commented
Sep 6, 2024
…th to generated json file
imcarolwang
force-pushed
the
issue5495
branch
from
September 18, 2024 06:01
8ffb4d7
to
33d576b
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
imcarolwang
force-pushed
the
issue5495
branch
from
October 18, 2024 12:10
d1c3b3e
to
1530698
Compare
imcarolwang
changed the title
dotnet-svcutil: write generated json file with name instead of full path for referenced assembly.
dotnet-svcutil: write generated json file with relative path for referenced assembly.
Oct 21, 2024
imcarolwang
force-pushed
the
issue5495
branch
from
October 21, 2024 07:22
5d866bc
to
9c7c503
Compare
imcarolwang
force-pushed
the
issue5495
branch
from
October 24, 2024 09:38
9c7c503
to
3f52c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #5495.
Write referenced assembly name instead of absolute path to the generated parameters json file, corresponding to the change, recalculate references base on project dependencies for update operation, update related test as well.