Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose IErrorHandler and add test case. #5593

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

imcarolwang
Copy link
Contributor

@imcarolwang imcarolwang commented Jun 27, 2024

For issue #5561.

@HongGit HongGit requested a review from mconnew July 8, 2024 21:20
@@ -1834,6 +1834,7 @@ internal ClientRuntime() { }
public System.Type ContractClientType { get { return default; } set { } }
public string ContractName { get { return default; } }
public string ContractNamespace { get { return default; } }
internal bool EnableFaults { get { return default; } set { } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to understand why you added this to the ref assembly as it's internal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the request at #5561 suggests adding ClientRuntime.EnableFaults. It is internal in the src implementation

, so I brought the same to the ref project.

Would you recommend that we update it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my mistake, we don't need to expose EnableFaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mconnew Thank you for letting me know. I’ve updated the PR to remove the exposure of "EnableFaults." Following your suggestion, I’ve rebased the branch and made changes only to the netcoreapp reference assembly by modifying the System.ServiceModel.Primitives.Netcoreapp.cs file. Would you mind taking another look when you have a chance to confirm if everything looks good now?

@mconnew
Copy link
Member

mconnew commented Nov 14, 2024

Everything looks good except the question around the internal EnableFaults. With the recent changes I made to support netstandard2.0 and netfx, we have multiple ref assemblies. When you rebase, only add to the netcoreapp ref assembly, we aren't updating the netstandard2.0 reference assembly beyond what it currently is as it's only there to support those using that capability from the 4.10.x packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants