Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Web.Services.Description missing NetFx type forwards #5708

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Dec 11, 2024

Also improved PackageVerifier to handle more scenarios and have better reporting

Improved PackageVerifier to handle more scenarios and have better reporting
@mconnew mconnew requested a review from Copilot December 11, 2024 06:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • System.ServiceModel.sln: Language not supported
  • eng/GenRefAssembly.targets: Language not supported
  • src/System.Web.Services.Description/ref/System.Web.Services.Description.Ref.csproj: Language not supported
  • src/System.Web.Services.Description/src/System.Web.Services.Description.csproj: Language not supported
Comments skipped due to low confidence (1)

src/System.Private.ServiceModel/tools/PackageChecker/Program.cs:37

  • The error message should be 'No assemblies found in a lib/net4?? folder. No type forwards to check.'
Console.Error.WriteLine("No assemblies found in a lib/net4?? folder. No type forwards to check.");
@HongGit HongGit merged commit 97a4b43 into dotnet:main Dec 11, 2024
6 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants