-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ActiveIssues for tests failing only on NET Native #917
Adding ActiveIssues for tests failing only on NET Native #917
Conversation
StephenBonikowsky
commented
Mar 16, 2016
- By wrapping the ActiveIssue in an #if #endif based on FEATURE_NETNATIVE we should be able to only skip these test on NET Native and not on NET Core.
This PR needs to be validated on an N from K run. |
I'm trying this out with ToF NET Native now |
Would you mind adding these new tests to that list? ActiveIssue is #832. They are under Security\TransportSecurity\Tcp\StreamingTests.cs
|
I'll add those as well Ron, I can confirm that it works as expected. |
44d0ab3
to
2fcf168
Compare
Verified all of this works on NET Native. |
[ActiveIssue(544, PlatformID.AnyUnix)] | ||
#if FEATURE_NETNATIVE | ||
[ActiveIssue(544)] // Server certificate validation not supported in NET Native | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect this test will pass on *nix now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, @mconnew would know. The issue implies that it works on Windows but not Unix, there is a later comment that says it is now supported on UWP.
If Matt fixed it and it now works on Unix he should verify it and remove the ActiveIssue?
LGTM. |
* By wrapping the ActiveIssue in an #if #endif based on FEATURE_NETNATIVE we should be able to only skip these test on NET Native and not on NET Core.
2fcf168
to
b84caec
Compare
Adding ActiveIssues for tests failing only on NET Native