Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

Set AddRazorSupportForMvc in the WebSDK #527

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Set AddRazorSupportForMvc in the WebSDK #527

merged 1 commit into from
Mar 26, 2019

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm requested review from vijayrkn and rynowak March 25, 2019 23:23
rynowak
rynowak reviewed Mar 25, 2019
View reviewed changes
src/Web/Targets/Sdk.props Outdated
@@ -30,6 +30,11 @@ Copyright (c) .NET Foundation. All rights reserved.

<Import Sdk="Microsoft.NET.Sdk.Publish" Project="Sdk.props" />

<PropertyGroup>
<!-- Configure the Razor SDK to add support for the MVC configuration -->
<AddRazorSupportForMvc>true</AddRazorSupportForMvc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be behind the same conditions as the framework reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has a couple of small issues - this is the props file, so it's being evaluated prior to project properties. We could move it to the targets file instead which would address this. However, DisableImplicitFrameworkReferences doesn't actually tell us if you didn't manually add a FrameworkReference to the SDK. The only real way to tell if the Framework reference is missing is to evaluate the itemgroup which is a no go.

That said, moving it to the target file would likely address the most common reason you'd have DisableImplicitFrameworkReferences in your project file.

@pranavkm pranavkm force-pushed the prkrishn/addrazorsupportformvc branch from b93a660 to c460178 Compare March 25, 2019 23:36
@pranavkm
Copy link
Contributor Author

🆙 📅

@pranavkm pranavkm merged commit 5e60026 into master Mar 26, 2019
@pranavkm
Copy link
Contributor Author

Thanks @vijayrkn

@pranavkm pranavkm deleted the prkrishn/addrazorsupportformvc branch March 26, 2019 00:03
vijayrkn pushed a commit that referenced this pull request Mar 30, 2019
@pranavkm @vijayrkn
Set AddRazorSupportForMvc in the WebSDK (#527)
419d91f 
Fixes dotnet/aspnetcore#6392
vijayrkn added a commit that referenced this pull request Apr 3, 2019
@vijayrkn
Merge master to Release/3.0 branch (#538)
3bdc5e8 
* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19163-08 (#516)

This change updates the following dependencies
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19163-08
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19163-08

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19165-04 (#517)

This change updates the following dependencies
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19165-04
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19165-04

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19166-02 (#518)

This change updates the following dependencies
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19166-02
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19166-02

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19168-01 (#519)

This change updates the following dependencies
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-01
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-01

* Fix typo in name and sync the version numbers of Analyzer packages

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19168-06 (#522)

This change updates the following dependencies
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19168-06
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19168-06

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19170-01 (#523)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19170-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19170-01

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19170-07 (#524)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19170-07
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19170-07

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19171-04 (#525)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19171-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19171-04

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19172-03 (#526)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19172-03
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19172-03

* Set AddRazorSupportForMvc in the WebSDK (#527)

Fixes dotnet/aspnetcore#6392

* Update dependencies from https://github.com/aspnet/AspNetCore build 3.0.0-preview4-19177-02 (#529)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19177-02
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19177-02

* Change build pool for internal builds (#531)

* Following the same folder structure as NetSdk (#533)

* Update dependencies from https://github.com/aspnet/AspNetCore build 20190329.3 (#535)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19179-03
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19179-03

* Update dependencies from https://github.com/aspnet/AspNetCore build 20190330.1 (#536)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19180-01
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19180-01

* Update dependencies from https://github.com/aspnet/AspNetCore build 20190401.4 (#537)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview4-19201-04
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview4-19201-04

* Moving the Import profile logic to a separate file (#534)

* Moving the Import profile logic to a separate file

* Removing an unwanted comment from the target file

* Splitting the Sdk and targets folder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak left review comments

@vijayrkn vijayrkn vijayrkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @rynowak @vijayrkn