-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Microsoft.Windows.Compatibility README.md #3835
Conversation
## Feedback | ||
|
||
We value your feedback! Here are ways to get in touch with us: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice phrase, we can use it in the System.Drawing.Common readme too!
You will cherry-pick this change to release/8.0 branch, right? |
``` | ||
Install-Package Microsoft.Windows.Compatibility -Version [your_version_here] | ||
``` | ||
|
||
### .NET CLI | ||
``` | ||
dotnet add package Microsoft.Windows.Compatibility --version [your_version_here] | ||
``` | ||
|
||
### Prerequisites | ||
|
||
- .NET Core 2.0+ | ||
- .NET 5+ | ||
- .NET Standard 2.0 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would then also count for System.Drawing.Common
, I suppose, which did not have a readme, either?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you already add a package readme for System.Drawing.Common? Yes, probably applies to that library as well.
@KlausLoeffelmann you accidentally updated the repo documentation for the Microsoft.Windows.Compatibility package which targets devs that need to update the library in this repository. Instead, the package readme should be named PACKAGE.md and the original README.md should be kept. Please see dotnet/runtime#91210 for an example of the PACKAGE.md and its format. In addition, your changes don't take effect unless you add this infrastructure:
You can set that directly in the Microsoft.Windows.Compatibility.csproj project file. |
Ah, shoot. OK, I am fixing that right now. The latter I did already in that one. |
* Update README.md * Update Code-Tic-Formatting in README.md * Address review feedback.
No description provided.