[release/10.0] Adopt WiX v5 installer for WindowsDesktop #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

merriemcgaw merged 8 commits into release/10.0 from WixV5Installer

Oct 10, 2025

+3,010 −1,159

Member

merriemcgaw commented Oct 7, 2025

Summary

replace the legacy WiX v3 bundle project with WiX v5 assets (bundle.wixproj, Wix.targets, bundle.wxs, supporting payload/theme files) and drop Microsoft.WindowsDesktop.App.Bundle.bundleproj
reintroduce and normalize deterministic upgrade/version logic so preview/RC → RTM upgrades work and GA bundles always version as 10.0.0.50000
add runtime MSI staging/restore scripts, new local build entry points, and pipeline updates to keep transport packages, arcade props, and documentation aligned with the new installer flow

Testing

dotnet msbuild src/windowsdesktop/src/bundle/bundle.wixproj /t:Build /p:RestoreRuntimePrereqs=false
✅ Produces artifacts\bin\bundle\Debug\windowsdesktop-runtime-10.0.0-dev-win-x64.exe

Manual testing across upgrade, downgrade, SxS and all architectures.

merriemcgaw requested a review from a team as a code owner

October 7, 2025 23:15

merriemcgaw requested review from JeremyKuhne, John-Hart, KlausLoeffelmann, PranavSenthilnathan, Shyam-Gupta, joeloff and wtgodbe

October 7, 2025 23:16

wtgodbe reviewed

View reviewed changes

Directory.Build.props Show resolved Hide resolved

wtgodbe reviewed

View reviewed changes

eng/Versions.props Outdated Show resolved Hide resolved

wtgodbe reviewed

View reviewed changes

src/windowsdesktop/src/Directory.Build.props Outdated Show resolved Hide resolved

wtgodbe reviewed

View reviewed changes

src/windowsdesktop/src/bundle/Product.targets Outdated Show resolved Hide resolved

wtgodbe reviewed

View reviewed changes

src/windowsdesktop/src/bundle/Wix.props Outdated Show resolved Hide resolved

wtgodbe reviewed

View reviewed changes

src/windowsdesktop/src/bundle/bundle.wixproj Show resolved Hide resolved

joeloff reviewed

View reviewed changes

src/windowsdesktop/src/bundle/bundle.wxs Outdated Show resolved Hide resolved

joeloff reviewed

View reviewed changes

src/windowsdesktop/src/bundle/bundle.wxs Show resolved Hide resolved

joeloff reviewed

View reviewed changes

src/windowsdesktop/src/bundle/bundle.wxs Outdated Show resolved Hide resolved

merriemcgaw added 3 commits

October 8, 2025 10:31


          Adopt WiX v5 installer with deterministic upgrades

f621175


          Address Will's review feedback

a0e7cbd


          Address joeloff's PR feedback: Add upgrade policy registry search ref…

1dc7743

…s and remove MSI InstallCondition attributes

merriemcgaw force-pushed the WixV5Installer branch from 43eaf07 to 1dc7743 Compare

October 8, 2025 21:33

merriemcgaw requested review from NikolaMilosavljevic, joeloff and wtgodbe

October 8, 2025 23:46

joeloff reviewed

View reviewed changes

src/windowsdesktop/src/bundle/theme/1033/bundle.wxl Show resolved Hide resolved

joeloff reviewed

View reviewed changes

src/windowsdesktop/src/bundle/bundle.wxs Show resolved Hide resolved

joeloff approved these changes

View reviewed changes

Shyam-Gupta and others added 2 commits

October 9, 2025 14:27


          Bundle.wxl localization files (#5328)

b6a4d8d

* Bundle.wxl localization files


          Fix SWID tag location, indentation, and enable backwards compatible G…

a04738d

…UID generation

merriemcgaw changed the title ~~Adopt WiX v5 installer with deterministic upgrades~~ Adopt WiX v5 installer for WindowsDesktop

joeloff approved these changes

View reviewed changes

Shyam-Gupta approved these changes

View reviewed changes

merriemcgaw added 3 commits

October 10, 2025 09:48


          Fix localization: Remove duplicate LCID 1033 from Payload loop

d0a6d92

LCID 1033 (English) was specified twice - once as the default
LocalizationFile attribute and again in the Payload foreach loop.
This duplication prevented WiX from properly loading alternate
language files based on system locale.

The LocalizationFile attribute should specify the default/fallback
language, with Payloads only for additional languages.


          Merge upstream/release/10.0 dependency flow updates

59d41ae


          Fix architecture-specific ProviderKey for side-by-side installations

cafc967

NikolaMilosavljevic approved these changes

View reviewed changes

merriemcgaw changed the title ~~Adopt WiX v5 installer for WindowsDesktop~~ [release/10.0] Adopt WiX v5 installer for WindowsDesktop

merriemcgaw merged commit a431566 into release/10.0

8 checks passed

merriemcgaw deleted the WixV5Installer branch

October 10, 2025 21:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Shyam-Gupta Shyam-Gupta approved these changes

KlausLoeffelmann Awaiting requested review from KlausLoeffelmann

JeremyKuhne Awaiting requested review from JeremyKuhne

PranavSenthilnathan Awaiting requested review from PranavSenthilnathan

John-Hart Awaiting requested review from John-Hart

wtgodbe Awaiting requested review from wtgodbe

+2 more reviewers

joeloff joeloff approved these changes

NikolaMilosavljevic NikolaMilosavljevic approved these changes

Labels

None yet