Merge pull request #11023 from LakshanF/TrimTestWrnFix2

Bubble up formatter trim warnings

Author: LakshanF

src/System.Windows.Forms/src/Resources/SR.resx

@@ -6964,4 +6964,7 @@ Stack trace where the illegal operation occurred was:
   <data name="FolderBrowserDialogMultiSelectDescr" xml:space="preserve">
     <value>Controls whether multiple folders can be selected in the dialog.</value>
   </data>
-</root>
+  <data name="BindingNotSupported" xml:space="preserve">
+    <value>Binding operations are not supported when application trimming is enabled.</value>
+  </data>
+</root>

src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf

@@ -1102,6 +1102,7 @@ internal BindingContext? BindingContextInternal
     public virtual BindingContext? BindingContext
     {
         get => BindingContextInternal;
+        [RequiresUnreferencedCode(IBindableComponent.ComponentModelTrimIncompatibilityMessage)]
         set => BindingContextInternal = value;
     }
 
@@ -7052,6 +7053,11 @@ protected virtual void OnBindingContextChanged(EventArgs e)
     {
         if (Properties.ContainsObjectThatIsNotNull(s_bindingsProperty))
         {
+            if (!Binding.IsSupported)
+            {
+                throw new NotSupportedException(SR.BindingNotSupported);
+            }
+
             UpdateBindings();
         }
 

src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf

@@ -680,6 +680,11 @@ private void SetDataConnection(object? newDataSource, BindingMemberInfo newDispl
                     CurrencyManager? newDataManager = null;
                     if (newDataSource is not null && BindingContext is not null && newDataSource != Convert.DBNull)
                     {
+                        if (!Binding.IsSupported)
+                        {
+                            throw new NotSupportedException(SR.BindingNotSupported);
+                        }
+
                         newDataManager = (CurrencyManager)BindingContext[newDataSource, newDisplayMember.BindingPath];
                     }
 

src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf

@@ -386,6 +386,8 @@ public override BindingContext? BindingContext
             // we don't have a binding context
             return null;
         }
+
+        [RequiresUnreferencedCode(IBindableComponent.ComponentModelTrimIncompatibilityMessage)]
         set
         {
             if (Properties.GetObject(s_propBindingContext) != value)

src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf

@@ -28,6 +28,7 @@ public BindingContext? BindingContext
     {
         get => _bindingContext ??= [];
 
+        [RequiresUnreferencedCode(IBindableComponent.ComponentModelTrimIncompatibilityMessage)]
         set
         {
             if (!Equals(_bindingContext, value))

src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf

@@ -12,6 +12,11 @@ namespace System.Windows.Forms;
 [TypeConverter(typeof(ListBindingConverter))]
 public partial class Binding
 {
+    [FeatureSwitchDefinition("System.Windows.Forms.Binding.IsSupported")]
+#pragma warning disable IDE0075 // Simplify conditional expression - the simpler expression is hard to read
+    internal static bool IsSupported => AppContext.TryGetSwitch("System.Windows.Forms.Binding.IsSupported", out bool isSupported) ? isSupported : true;
+#pragma warning restore IDE0075 //Simplify conditional expression
+
     private BindingManagerBase? _bindingManagerBase;
 
     private readonly BindToObject _bindToObject;

src/System.Windows.Forms/src/Resources/xlf/SR.ja.xlf

@@ -7,6 +7,12 @@ namespace System.Windows.Forms;
 
 public interface IBindableComponent : IComponent
 {
+    internal const string ComponentModelTrimIncompatibilityMessage = "Binding is not supported with trimming";
     ControlBindingsCollection DataBindings { get; }
-    BindingContext? BindingContext { get; set; }
+    BindingContext? BindingContext
+    {
+        get;
+        [RequiresUnreferencedCode(ComponentModelTrimIncompatibilityMessage)]
+        set;
+    }
 }

src/System.Windows.Forms/src/Resources/xlf/SR.ko.xlf

@@ -9,12 +9,13 @@ namespace System.Windows.Forms;
 
 internal static class Formatter
 {
+    internal const string ComponentModelTrimIncompatibilityMessage = "ComponentModel APIs are not trimming compatible.";
+
     private static readonly Type s_stringType = typeof(string);
     private static readonly Type s_booleanType = typeof(bool);
     private static readonly Type s_checkStateType = typeof(CheckState);
     private static readonly object s_parseMethodNotFound = new();
     private static readonly object s_defaultDataSourceNullValue = DBNull.Value;
-
     /// <summary>
     ///  Converts a binary value into a format suitable for display to the end user.
     ///  Used when pushing a value from a back-end data source into a data-bound property on a control.
@@ -25,6 +26,7 @@ internal static class Formatter
     ///  If the caller is expecting a nullable value back, we must also re-wrap the final result
     ///  inside a nullable value before returning.
     /// </summary>
+    [RequiresUnreferencedCode(ComponentModelTrimIncompatibilityMessage)]
     public static object? FormatObject(
         object? value,
         Type targetType,
@@ -82,6 +84,7 @@ internal static class Formatter
     ///  - Uses TypeConverters or IConvertible where appropriate
     ///  - Throws a FormatException is no suitable conversion can be found
     /// </summary>
+    [RequiresUnreferencedCode(ComponentModelTrimIncompatibilityMessage)]
     private static object? FormatObjectInternal(
         object? value,
         Type targetType,
@@ -431,7 +434,7 @@ private static CultureInfo GetFormatterCulture(IFormatProvider? formatInfo)
     /// <summary>
     ///  Converts a value to the specified type using best Parse() method on that type
     /// </summary>
-    public static object? InvokeStringParseMethod(object? value, Type targetType, IFormatProvider? formatInfo)
+    public static object? InvokeStringParseMethod(object? value, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)] Type targetType, IFormatProvider? formatInfo)
     {
         try
         {

src/System.Windows.Forms/src/Resources/xlf/SR.pl.xlf

@@ -260,6 +260,8 @@ public override BindingContext? BindingContext
 
             return bm;
         }
+
+        [RequiresUnreferencedCode(IBindableComponent.ComponentModelTrimIncompatibilityMessage)]
         set => base.BindingContext = value;
     }
 

src/System.Windows.Forms/src/Resources/xlf/SR.pt-BR.xlf

@@ -219,6 +219,8 @@ public override BindingContext? BindingContext
         {
             return BindingContextInternal;
         }
+
+        [RequiresUnreferencedCode(IBindableComponent.ComponentModelTrimIncompatibilityMessage)]
         set
         {
             BindingContextInternal = value;