Bubble up formatter trim warnings

[LakshanF]

Bubbling up trim warnings to the public surface or to the binding feature boundary area seen by the TrimTest project. This is the first iteration of getting the TrimTest project warnings towards zero as discussed here. Binding feature boundary is guarded by a feature check and added a RUC to BindingContext setter so as to generate warnings when using binding in WinForms trimming. The intention is applications like TrimTest that doesn't use binding will not generate warnings but applications that do use binding will get warnings at build time (when they use BindingContext ). The runtime behavior will be a throw for trimmed WinForms applications if they use binding.

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.34303%. Comparing base (fd95fcd) to head (7ca07fb).
Report is 3 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #11023         +/-   ##
===================================================
+ Coverage   73.22354%   73.34303%   +0.11948%     
===================================================
  Files           3096        3094          -2     
  Lines         633620      632450       -1170     
  Branches       47336       46945        -391     
===================================================
- Hits          463959      463858        -101     
+ Misses        166112      165110       -1002     
+ Partials        3549        3482         -67     

Flag	Coverage Δ
Debug	73.34303% <22.22222%> (+0.11948%)	⬆️
integration	18.46261% <22.22222%> (+0.04268%)	⬆️
production	46.84423% <22.22222%> (+0.13377%)	⬆️
test	94.98048% <ø> (+0.00097%)	⬆️
unit	43.72135% <22.22222%> (+0.10486%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sbomer]

Is this code path hit at runtime by the test app? I don't know whether we should bubble up warnings, or carve out a trim-compatible path through this method. If we bubble it up, I'd like to understand where we are going to cut off the annotations so that the test app doesn't hit warnings due to this.

[LakshanF]

ParseObjectInternal path is not hit at runtime. Added feature guards on the call stack path that reach the binding boundary. FormatObjectInternal is hit at runtime by the runtime app and bubbled up its RUC to publish methods.

[KlausLoeffelmann]

Just had two suggestions for making messages a bit clearer - otherwise fine!

[KlausLoeffelmann]

[KlausLoeffelmann]