Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug Assert Failing Tests in Windows 8.1 #534

Closed
zsd4yr opened this issue Mar 7, 2019 · 0 comments · Fixed by #3219
Closed

Debug Assert Failing Tests in Windows 8.1 #534

zsd4yr opened this issue Mar 7, 2019 · 0 comments · Fixed by #3219
Labels
🪲 bug Product bug (most likely) good first issue Issue should be easy to implement, good for first-time contributors

Comments

@zsd4yr
Copy link
Contributor

zsd4yr commented Mar 7, 2019 •
edited
Loading

There may be more but here is an example on TryGetSystemMetricsForDpi in UnsafeNativeMethods

This is a Windows 8.1 Testing blocker as we wish to test debug skews to discover paths which differ between Release and Debug configurations.

This should not be here. Debug Asserts should not be present if there is a way out of the build. Instead, this should be Trace.WriteLine or it should not exist.
@dreddy-work dreddy-work added 🪲 bug Product bug (most likely) good first issue Issue should be easy to implement, good for first-time contributors labels Mar 15, 2019
@merriemcgaw merriemcgaw modified the milestones: 3.0, Future Apr 3, 2019
@hughbe hughbe mentioned this issue May 5, 2020
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label May 5, 2020
@ghost ghost removed the 🚧 work in progress Work that is current in progress label May 7, 2020
@RussKie RussKie removed this from the Future milestone May 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🪲 bug Product bug (most likely) good first issue Issue should be easy to implement, good for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove invalid debug assert in GetSystemMetricsForDpi hughbe/winforms
4 participants
@RussKie @zsd4yr @merriemcgaw @dreddy-work