Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid debug assert in GetSystemMetricsForDpi #3219

Merged
merged 1 commit into from
May 7, 2020

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented May 5, 2020

We shouldn't have this throw an error because some machines run on windows 8, for example, which we support

Fixes #534
Contributes to #3121

Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner May 5, 2020 15:04
@ghost ghost assigned hughbe May 5, 2020
@hughbe hughbe force-pushed the Remove-DebugAsser branch from 99ce62b to 2efb29a Compare May 5, 2020 15:28
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #3219 into master will decrease coverage by 28.80329%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##              master       #3219          +/-   ##
====================================================
- Coverage   61.58510%   32.78181%   -28.80329%     
====================================================
  Files           1286         866         -420     
  Lines         451960      254086      -197874     
  Branches       39502       36748        -2754     
====================================================
- Hits          278340       83294      -195046     
+ Misses        168268      165992        -2276     
+ Partials        5352        4800         -552     
Flag Coverage Δ
#Debug 32.78181% <ø> (-28.80329%) ⬇️
#production 32.78181% <ø> (-0.02638%) ⬇️
#test ?

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a strange assert indeed.

@RussKie RussKie merged commit bb5b5ce into dotnet:master May 7, 2020
@ghost ghost added this to the 5.0 Preview5 milestone May 7, 2020
@hughbe hughbe deleted the Remove-DebugAsser branch May 7, 2020 07:46
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug Assert Failing Tests in Windows 8.1
2 participants