Use collection expressions to init spans where possible #10114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halgab
force-pushed
the
collection-literal
branch
from
49d7951 to
d1a13a2
Compare
src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Automation/UiaTextProvider.cs
Show resolved
Hide resolved
Tanya-Solyanik
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
Tanya-Solyanik
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
halgab
force-pushed
the
collection-literal
branch
from
18639ad to
7bbaa42
Compare
Tanya-Solyanik
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
halgab
force-pushed
the
collection-literal
branch
from
1e08310 to
59e3fcf
Compare
Tanya-Solyanik
previously approved these changes
Oct 30, 2023
Tanya-Solyanik
added
the
ready-to-merge
Tanya-Solyanik
removed
the
ready-to-merge
Tanya-Solyanik
added
the
📭 waiting-author-feedback
halgab
force-pushed
the
collection-literal
branch
from
59e3fcf to
33c534a
Compare
ghost
removed
the
📭 waiting-author-feedback
halgab
force-pushed
the
collection-literal
branch
from
33c534a to
d2e830a
Compare
Tanya-Solyanik
added a commit
that referenced
this pull request
Nov 20, 2023
#10335) Partially reverted https://github.com/dotnet/winforms/pull/9654/files, to move forward PR #10114 After the change, according to the Build.binlog, command line build uses Roslyn binaries that are distributed with arcade - .dotnet\sdk\9.0.100-alpha.1.23511.2\Roslyn\bincore\csc.dll Microsoft (R) Visual C# Compiler version 4.8.0-3.23477.1 (a0f63522) Commit associated with this version was merged in September - dotnet/roslyn@a0f63522, after the commit where the inline arrays were introduced, which was in August.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same thing that was done in dotnet/runtime#93125
Proposed changes
Microsoft Reviewers: Open in CodeFlow