Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for WebBrowserBase #10755

Conversation

SimonZhao888
Copy link
Member

@SimonZhao888 SimonZhao888 commented Jan 29, 2024

Related #10453

Proposed changes

  • Add Unit test for WebBrowserBase

Regression?

  • No

Risk

  • Minimal
Microsoft Reviewers: Open in CodeFlow

@SimonZhao888 SimonZhao888 requested a review from a team as a code owner January 29, 2024 03:02
@ghost ghost assigned SimonZhao888 Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5207c65) 72.65688% compared to head (b17c9e3) 72.58542%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10755         +/-   ##
===================================================
- Coverage   72.65688%   72.58542%   -0.07147%     
===================================================
  Files           2906        2929         +23     
  Lines         622321      620159       -2162     
  Branches       46900       46936         +36     
===================================================
- Hits          452159      450145       -2014     
+ Misses        161832      161667        -165     
- Partials        8330        8347         +17     
Flag Coverage Δ
Debug 72.58542% <100.00000%> (-0.07147%) ⬇️
production 43.54391% <ø> (+0.06418%) ⬆️
test 97.37429% <100.00000%> (+0.03104%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardobossan
ricardobossan previously approved these changes Jan 29, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Jan 29, 2024
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Feb 2, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit da7b855 into dotnet:main Feb 3, 2024
9 checks passed
@ghost ghost added this to the 9.0 Preview2 milestone Feb 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants