Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for TrackBar #11066

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Mar 18, 2024

Related #10453

Proposed changes

  • Add unit tests for TrackBar to test its events: AutoSizeChanged and Paints.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.36326%. Comparing base (fccada2) to head (6b0ef44).
Report is 19 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11066         +/-   ##
===================================================
- Coverage   73.36695%   73.36326%   -0.00370%     
===================================================
  Files           3094        3099          +5     
  Lines         632406      632844        +438     
  Branches       46857       46880         +23     
===================================================
+ Hits          463977      464275        +298     
- Misses        164981      165101        +120     
- Partials        3448        3468         +20     
Flag Coverage Δ
Debug 73.36326% <100.00000%> (-0.00370%) ⬇️
integration 18.28130% <ø> (-0.16675%) ⬇️
production 46.80376% <ø> (-0.05556%) ⬇️
test 94.98443% <100.00000%> (+0.00132%) ⬆️
unit 43.84978% <ø> (+0.08026%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik
Copy link
Member

@Syareel-Sukeri - we had recently enabled multiple analyzers in this repo, please update your change to follow these new rules. You will see warning and error when you build your branch in the VisualStudio after rebasing your branch on the latest main. Resolve these warnings and errors by clicking on the "code-fix" icons - light bulbs.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Mar 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 20, 2024
lonitra
lonitra previously approved these changes Mar 20, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Mar 20, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed ready-to-merge PRs that are ready to merge but worth notifying the internal team. labels Mar 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 21, 2024
@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Mar 21, 2024
@lonitra lonitra merged commit 5a5f0d9 into dotnet:main Mar 22, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Mar 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants