Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous trim fixes #11175

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

LakshanF
Copy link
Contributor

@LakshanF LakshanF commented Apr 8, 2024

Addresses the following warnings

Microsoft Reviewers: Open in CodeFlow

@LakshanF LakshanF self-assigned this Apr 8, 2024
@LakshanF LakshanF requested a review from a team as a code owner April 8, 2024 18:00
sbomer
sbomer previously approved these changes Apr 8, 2024
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing up the DesignerHost warnings I missed!

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.46668%. Comparing base (0e3964e) to head (1facc7c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11175         +/-   ##
===================================================
+ Coverage   73.44901%   73.46668%   +0.01766%     
===================================================
  Files           3098        3100          +2     
  Lines         632225      632352        +127     
  Branches       46653       46658          +5     
===================================================
+ Hits          464363      464568        +205     
+ Misses        164473      164386         -87     
- Partials        3389        3398          +9     
Flag Coverage Δ
Debug 73.46668% <0.00000%> (+0.01766%) ⬆️
integration 18.36740% <0.00000%> (+0.00121%) ⬆️
production 46.94527% <0.00000%> (+0.02844%) ⬆️
test 94.98748% <ø> (+0.00149%) ⬆️
unit 43.91138% <0.00000%> (+0.05389%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

…gn/DesignerHost.cs

Co-authored-by: Sven Boemer <sbomer@gmail.com>
sbomer
sbomer previously approved these changes Apr 9, 2024
@LakshanF LakshanF merged commit 477393f into dotnet:main Apr 10, 2024
8 checks passed
@LakshanF LakshanF deleted the TrimMiscellaneousFixes branch April 10, 2024 12:25
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Apr 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants