Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for TreeView #11293

Merged
merged 2 commits into from
May 10, 2024
Merged

Add test coverage for TreeView #11293

merged 2 commits into from
May 10, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Apr 30, 2024

related #10453

Proposed changes

  • Add unit tests for TreeView to test its properties: Name, IsReadOnly, ContextMenuStrip, RowBounds, IsVisible, IsExpanded, EnsureVisible
  • Add unit tests for TreeView to test its methods: GetChildCount, Add, Insert, CanConvertTo, ConvertTo, HitTest, FromHandle, ExpandAll, Clone, Collapse, GetNodeCount, Toggle

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner April 30, 2024 02:24
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31701%. Comparing base (4317f31) to head (086a266).
Report is 32 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11293         +/-   ##
===================================================
- Coverage   74.32617%   74.31701%   -0.00917%     
===================================================
  Files           3018        3025          +7     
  Lines         626381      627684       +1303     
  Branches       46602       46987        +385     
===================================================
+ Hits          465565      466476        +911     
- Misses        157419      157808        +389     
- Partials        3397        3400          +3     
Flag Coverage Δ
Debug 74.31701% <100.00000%> (-0.00917%) ⬇️
integration 18.26802% <ø> (-0.04285%) ⬇️
production 47.08904% <ø> (+0.11654%) ⬆️
test 97.04319% <100.00000%> (+0.00166%) ⬆️
unit 44.05184% <ø> (+0.13413%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 30, 2024
@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 2, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 7, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label May 7, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra
Copy link
Member

lonitra commented May 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lonitra lonitra enabled auto-merge (squash) May 10, 2024 01:42
@lonitra lonitra merged commit 296fd9e into dotnet:main May 10, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone May 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label May 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants