Utilize TypeName Parser API in ResXSerializationBinder #11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @adamsitnik |
lonitra
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11312 +/- ##
===================================================
- Coverage 74.35035% 74.22294% -0.12742%
===================================================
Files 3019 3021 +2
Lines 626605 626146 -459
Branches 46604 46693 +89
===================================================
- Hits 465883 464744 -1139
- Misses 157321 158005 +684
+ Partials 3401 3397 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
previously approved these changes
May 3, 2024
| typeName.Should().Be(typeName); | ||
| } | ||
|
|
||
| private class CustomTypeResolutionService : ITypeResolutionService |
There was a problem hiding this comment.
Consider giving this class a more descriptive name that would explain what is customization it has. I.e. this service is not only resolving the test types, but also tracks how they were resolved.
| { | ||
| TypeName parsed = TypeName.Parse($"{typeof(Form).FullName}, {typeof(Form).Assembly.FullName}"); | ||
| AssemblyNameInfo? assemblyNameInfo = parsed.AssemblyName; | ||
| _formNoVersionFullyQualifiedName = $"{typeof(Form).FullName}, {new AssemblyNameInfo( |
There was a problem hiding this comment.
You only need this string in one test, consider initializing it when needed only.
JeremyKuhne
approved these changes
May 6, 2024
Tanya-Solyanik
approved these changes
May 6, 2024
|
Sent from my iPhoneOn May 6, 2024, at 7:00 PM, Loni Tra ***@***.***> wrote:
Merged #11312 into main.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResXSerializationBinderwhere we had been manually picking apart the type name to redirect to/from .NET Framework type namesMicrosoft Reviewers: Open in CodeFlow