Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for MaskedTextBox #11376

Merged
merged 5 commits into from
May 28, 2024
Merged

Add test coverage for MaskedTextBox #11376

merged 5 commits into from
May 28, 2024

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented May 15, 2024 •
edited
Loading

Related #10453

Proposed changes

  • Add unit tests for MaskedTextBox to test its properties: MaskedTextBox_RejectInputOnFirstFailure, ResetOnPrompt, ValidatingType, PromptChar, PasswordChar.
  • Add unit tests for MaskedTextBox to test its events: TypeValidationCompletedEvent.
  • Add unit tests for MaskedTextBox to test its methods: GetCharFromPosition, GetCharIndexFromPosition, GetPositionFromCharIndex, ValidateText.
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner May 15, 2024 07:49
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31702%. Comparing base (f2118b8) to head (56e598f).
Report is 33 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11376         +/-   ##
===================================================
+ Coverage   74.27372%   74.31702%   +0.04330%     
===================================================
  Files           3025        3026          +1     
  Lines         626861      627248        +387     
  Branches       46742       46760         +18     
===================================================
+ Hits          465593      466152        +559     
+ Misses        157926      157751        -175     
- Partials        3342        3345          +3
Flag Coverage Δ
Debug 74.31702% <100.00000%> (+0.04330%) ⬆️
integration 17.99788% <ø> (+0.00194%) ⬆️
production 47.07239% <ø> (+0.07069%) ⬆️
test 96.98852% <100.00000%> (-0.00564%) ⬇️
unit 44.04772% <ø> (+0.07663%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LeafShi1 LeafShi1 mentioned this pull request May 16, 2024
Open
3 tasks
@SimonZhao888 SimonZhao888 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 16, 2024
@MelonWang1
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 11376 in repo dotnet/winforms

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 23, 2024
lonitra
lonitra reviewed May 23, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM

src/System.Windows.Forms/tests/UnitTests/MaskedTextBoxTests.cs Outdated Show resolved Hide resolved
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label May 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 24, 2024
@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label May 24, 2024
@lonitra lonitra merged commit 10c3fcc into dotnet:main May 28, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone May 28, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label May 28, 2024
@MelonWang1 MelonWang1 deleted the Add_test_coverage_for_MaskedTextBox branch May 31, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

@SimonZhao888 SimonZhao888 SimonZhao888 left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@lonitra lonitra lonitra approved these changes

Assignees

@MelonWang1 MelonWang1

Labels
None yet
Projects
None yet
Milestone
9.0 Preview6
Development

Successfully merging this pull request may close these issues.
6 participants
@MelonWang1 @Tanya-Solyanik @lonitra @SimonZhao888 @Epica3055 @elachlan