Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Coverage For ToolStrip #11464

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add Code Coverage For ToolStrip #11464

merged 4 commits into from
Jun 4, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented May 31, 2024

related #10453

Proposed changes

  • Add unit tests for ToolStrip to test its properties: Visible, Size, BackgroundImage, CausesValidation, ContextMenuStrip, CausesValidation, Cursor, ForeColor
  • Add unit tests for ToolStrip to test its methods: Compare(), Show()
  • Add unit tests for ToolStrip to test its events: DockChanged, BackColorChanged, BackgroundImageChanged, BackgroundImageLayoutChanged, BottomToolStripPanelVisible,CausesValidationChanged, ContextMenuStripChanged, CursorChanged
Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner May 31, 2024 08:54
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 99.58159% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.39993%. Comparing base (3ba919b) to head (324fd5c).
Report is 41 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11464         +/-   ##
===================================================
+ Coverage   74.27644%   74.39993%   +0.12349%     
===================================================
  Files           3026        3029          +3     
  Lines         626966      627760        +794     
  Branches       46753       46770         +17     
===================================================
+ Hits          465688      467053       +1365     
+ Misses        157924      157364        -560     
+ Partials        3354        3343         -11     
Flag Coverage Δ
Debug 74.39993% <99.58159%> (+0.12349%) ⬆️
integration 17.99707% <ø> (+0.00361%) ⬆️
production 47.22237% <ø> (+0.21540%) ⬆️
test 96.98853% <99.58159%> (+0.00075%) ⬆️
unit 44.17959% <ø> (+0.19375%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 31, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jun 3, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jun 3, 2024
@SimonZhao888 SimonZhao888 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jun 3, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jun 3, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jun 3, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lonitra lonitra merged commit 8a67b28 into dotnet:main Jun 4, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone Jun 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jun 4, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_ToolStrip branch June 5, 2024 02:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants