Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage for monthcalendar #11519

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Add code coverage for monthcalendar #11519

merged 3 commits into from
Jun 17, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jun 12, 2024 •
edited by dotnet-policy-service bot
Loading

related #10453

Proposed changes

  • Add unit tests for MonthCalendar to test its properties:ShouldSerializeTodayDate, ShouldSerializeAnnuallyBoldedDates ,ShouldSerializeBoldedDates, ShouldSerializeMonthlyBoldedDates, ShouldSerializeMaxDate,ShouldSerializeMinDate, ShouldSerializeTrailingForeColor, ShouldSerializeTitleForeColor, ShouldSerializeTitleBackColor, CanGetDescriptionInternal,
  • Add unit tests for MonthCalendar to test its methods: ResetTodayDate, ResetTitleBackColor, ResetTrailingForeColor, ResetTitleForeColor, ResetSelectionRange, ResetMonthlyBoldedDates, ResetMaxDate, ResetCalendarDimensions, ResetAnnuallyBoldedDates, ResetBoldedDates, RaiseMouseClick, DoDefaultAction
  • Add unit tests for MonthCalendar to test its events: _onCalendarViewChanged
Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner June 12, 2024 07:59
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.85057% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.41921%. Comparing base (481bb3d) to head (778df44).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11519         +/-   ##
===================================================
+ Coverage   74.41264%   74.41921%   +0.00657%     
===================================================
  Files           3029        3032          +3     
  Lines         627892      628370        +478     
  Branches       46770       46840         +70     
===================================================
+ Hits          467231      467628        +397     
- Misses        157317      157379         +62     
- Partials        3344        3363         +19
Flag Coverage Δ
Debug 74.41921% <98.85057%> (+0.00657%) ⬆️
integration 17.98278% <ø> (-0.01465%) ⬇️
production 47.26562% <ø> (+0.02711%) ⬆️
test 96.96763% <98.85057%> (-0.02206%) ⬇️
unit 44.25062% <ø> (+0.05489%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jun 12, 2024
@Zheng-Li01 @Epica3055
Update src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/…
778df44 
…MonthCalendarTests.cs

Co-authored-by: Epica3055 <135201996+Epica3055@users.noreply.github.com>
lonitra
lonitra approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jun 14, 2024
@LeafShi1 LeafShi1 mentioned this pull request Jun 17, 2024
Open
3 tasks
@LeafShi1 LeafShi1 merged commit 630549e into dotnet:main Jun 17, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jun 17, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_MonthCalenadr branch June 17, 2024 09:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

@lonitra lonitra lonitra approved these changes

Assignees

@Zheng-Li01 Zheng-Li01

Labels
None yet
Projects
None yet
Milestone
9.0 Preview6
Development

Successfully merging this pull request may close these issues.
4 participants
@Zheng-Li01 @lonitra @Epica3055 @LeafShi1