Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for LabelAccessibleObject #11521

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jun 12, 2024

Related #10453

Proposed changes

  • Add unit tests for Label.LabelAccessibleObject to test Name property
Microsoft Reviewers: Open in CodeFlow

@Olina-Zhang Olina-Zhang requested a review from a team as a code owner June 12, 2024 09:54
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.40402%. Comparing base (10c3fcc) to head (3eb9d5c).
Report is 64 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11521         +/-   ##
===================================================
+ Coverage   74.34475%   74.40402%   +0.05926%     
===================================================
  Files           3028        3032          +4     
  Lines         627396      628212        +816     
  Branches       46768       46813         +45     
===================================================
+ Hits          466436      467415        +979     
+ Misses        157612      157450        -162     
+ Partials        3348        3347          -1     
Flag Coverage Δ
Debug 74.40402% <100.00000%> (+0.05926%) ⬆️
integration 17.99016% <ø> (-0.00340%) ⬇️
production 47.24843% <ø> (+0.12313%) ⬆️
test 96.96449% <100.00000%> (-0.02206%) ⬇️
unit 44.20326% <ø> (+0.12082%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Jun 12, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comment, LGTM.

@ricardobossan ricardobossan added the 📭 waiting-author-feedback The team requires more information from the author label Jun 13, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jun 14, 2024
@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jun 14, 2024
@LeafShi1 LeafShi1 merged commit 8cbf7ea into dotnet:main Jun 17, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jun 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@Olina-Zhang Olina-Zhang deleted the LabelAccessibileObject_UnitTest branch July 22, 2024 01:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants