Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for PropertyGrid #11587

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Jun 26, 2024

Related #10453

Proposed changes

  • Add unit tests for PropertyGrid to test its events: SelectedGridItemChanged, PropertyTabChanged.
  • Add unit tests for PropertyGridToolStripAccessibleObject to test its methods: Name.
Microsoft Reviewers: Open in CodeFlow

@MelonWang1 MelonWang1 requested a review from a team as a code owner June 26, 2024 03:12
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.51708%. Comparing base (dd6025d) to head (f1fd67d).
Report is 17 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11587         +/-   ##
===================================================
+ Coverage   74.42978%   74.51708%   +0.08730%     
===================================================
  Files           3039        3040          +1     
  Lines         629056      629559        +503     
  Branches       46834       46839          +5     
===================================================
+ Hits          468205      469129        +924     
+ Misses        157501      157060        -441     
- Partials        3350        3370         +20     
Flag Coverage Δ
Debug 74.51708% <100.00000%> (+0.08730%) ⬆️
integration 17.88638% <ø> (-0.01611%) ⬇️
production 47.41442% <ø> (+0.16512%) ⬆️
test 96.95215% <100.00000%> (-0.00048%) ⬇️
unit 44.52020% <ø> (+0.20228%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Jun 26, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when addressed colleagues comments

@Zheng-Li01 Zheng-Li01 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 1, 2024
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Jul 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 2, 2024
@lonitra lonitra merged commit 48da9be into dotnet:main Jul 2, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 2, 2024
@MelonWang1 MelonWang1 deleted the Add_test_coverage_for_PropertyGrid branch July 18, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants