Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test case for DataGridView 21 events #11691

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add unit test case for DataGridView 21 events #11691

merged 2 commits into from
Jul 18, 2024

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Jul 17, 2024 •
edited by dotnet-policy-service bot
Loading

related #10453

Proposed changes

  • Add unit tests for below 21 events
  1. AutoSizeColumnsModeChanged
  2. AutoSizeRowsModeChanged
  3. CellDoubleClick
  4. CellEndEdit
  5. CellEnter
  6. CellFormatting
  7. CellLeave
  8. CellMouseClick
  9. CellMouseDoubleClick
  10. ColumnDividerDoubleClick
  11. ColumnHeaderMouseClick
  12. ColumnHeaderMouseDoubleClick
  13. ColumnHeaderCellChanged
  14. ColumnMinimumWidthChanged
  15. ColumnNameChanged
  16. ColumnRemoved
  17. ColumnSortModeChanged
  18. ColumnToolTipTextChanged
  19. ColumnWidthChanged
  20. DataBindingComplete
  21. DefaultValuesNeeded
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner July 17, 2024 09:35
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jul 17, 2024
Tanya-Solyanik
Tanya-Solyanik reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added only minor comments

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewTests.cs Outdated Show resolved Hide resolved
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 18, 2024
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jul 18, 2024
Tanya-Solyanik
Tanya-Solyanik approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 99.75962% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.70269%. Comparing base (fa07c1b) to head (af640cc).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11691         +/-   ##
===================================================
+ Coverage   74.55969%   74.70269%   +0.14300%     
===================================================
  Files           3041        3042          +1     
  Lines         629780      630225        +445     
  Branches       46845       46846          +1     
===================================================
+ Hits          469562      470795       +1233     
+ Misses        156849      156069        -780     
+ Partials        3369        3361          -8
Flag Coverage Δ
Debug 74.70269% <99.75962%> (+0.14300%) ⬆️
integration 17.94658% <ø> (+0.07383%) ⬆️
production 47.71637% <ø> (+0.26963%) ⬆️
test 96.98220% <99.75962%> (+0.00395%) ⬆️
unit 44.75995% <ø> (+0.18750%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra merged commit 1fe5058 into dotnet:main Jul 18, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 18, 2024
@LeafShi1 LeafShi1 mentioned this pull request Jul 24, 2024
Open
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonitra lonitra lonitra approved these changes

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Assignees

@John-Qiao John-Qiao

Labels
None yet
Projects
None yet
Milestone
9.0 Preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Qiao @Tanya-Solyanik @lonitra