Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage for ListBoxAccessibleObject and ListBoxItemAccessib… #11724

Merged
merged 16 commits into from
Sep 9, 2024
Merged

Add code coverage for ListBoxAccessibleObject and ListBoxItemAccessib… #11724

merged 16 commits into from
Sep 9, 2024

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Jul 22, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10453

Proposed changes

  • Add unit test for ListBoxAccessibleObject to test its property: State
  • Add unit test for ListBoxAccessibleObject to test its method: GetChild, GetFocused, GetSelected, HitTest, GetChildCount
  • Add unit test for ListBoxItemAccessibleObject to test its properties: Bounds, DefaultAction, Role
  • Add unit test for ListBoxItemAccessibleObject to test its method: DoDefaultAction, Select
Microsoft Reviewers: Open in CodeFlow

@Syareel-Sukeri Syareel-Sukeri requested a review from a team as a code owner July 22, 2024 06:28
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18993%. Comparing base (10ce899) to head (3eba7a6).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11724         +/-   ##
===================================================
+ Coverage   75.16445%   75.18993%   +0.02548%     
===================================================
  Files           3070        3072          +2     
  Lines         632561      632719        +158     
  Branches       46788       46794          +6     
===================================================
+ Hits          475461      475741        +280     
+ Misses        153724      153584        -140     
- Partials        3376        3394         +18
Flag Coverage Δ
Debug 75.18993% <100.00000%> (+0.02548%) ⬆️
integration 18.04090% <ø> (+0.07300%) ⬆️
production 48.43348% <ø> (+0.04291%) ⬆️
test 97.02146% <100.00000%> (+0.00135%) ⬆️
unit 45.42884% <ø> (+0.02145%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Tanya-Solyanik
Tanya-Solyanik reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added only a minor comment.

...UnitTests/System/Windows/Forms/AccessibleObjects/ListBox.ListBoxItemAccessibleObjectTests.cs Outdated Show resolved Hide resolved
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Jul 22, 2024
@lonitra lonitra changed the base branch from main to feature/10.0 July 23, 2024 00:52
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 23, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Jul 23, 2024
@LeafShi1 LeafShi1 mentioned this pull request Jul 24, 2024
Open
3 tasks
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 24, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Aug 5, 2024
Tanya-Solyanik
Tanya-Solyanik reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I did only a cursory review.

@LeafShi1 , @SimonZhao888 , @ricardobossan , @Epica3055 - could one of you review it please?

...UnitTests/System/Windows/Forms/AccessibleObjects/ListBox.ListBoxItemAccessibleObjectTests.cs Outdated Show resolved Hide resolved
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Aug 7, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Aug 20, 2024
@Syareel-Sukeri Syareel-Sukeri added waiting-review This item is waiting on review by one or more members of team 📭 waiting-author-feedback The team requires more information from the author and removed 📭 waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team labels Aug 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 20, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Aug 22, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Aug 27, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 28, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Aug 28, 2024
SimonZhao888
SimonZhao888 previously approved these changes Aug 28, 2024
View reviewed changes
Tanya-Solyanik
Tanya-Solyanik reviewed Sep 1, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

...ystem.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ListBoxAccesibleObjectTests.cs Outdated Show resolved Hide resolved
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 9, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Sep 9, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 463173d into dotnet:main Sep 9, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonitra lonitra lonitra left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@SimonZhao888 SimonZhao888 SimonZhao888 left review comments

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

@Epica3055 Epica3055 Awaiting requested review from Epica3055

@ricardobossan ricardobossan Awaiting requested review from ricardobossan

Assignees

@Syareel-Sukeri Syareel-Sukeri

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@Syareel-Sukeri @Tanya-Solyanik @lonitra @SimonZhao888