Add code coverage for comboBox #12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-Solyanik
requested review from
LeafShi1,
ricardobossan,
Epica3055 and
SimonZhao888
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12038 +/- ##
===================================================
+ Coverage 75.01536% 75.17159% +0.15622%
===================================================
Files 3047 3070 +23
Lines 631584 632606 +1022
Branches 46764 46789 +25
===================================================
+ Hits 473785 475540 +1755
+ Misses 154434 153689 -745
- Partials 3365 3377 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
reviewed
Sep 4, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
LeafShi1
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Nora-Zhou01
added
the
waiting-review
lonitra
reviewed
Sep 5, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
lonitra
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Epica3055
reviewed
Sep 6, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Add unit tests for ComboBox to test its event: MeasureItem, Paint
Microsoft Reviewers: Open in CodeFlow