Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for ToolStripSplitStackDragDropHandler #12082

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Sep 9, 2024

related #10453

Proposed changes
Add unit tests for ToolStripSplitStackDragDropHandler to test its properties & methods & events

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20629%. Comparing base (9efaa4b) to head (1ba1d9d).
Report is 20 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12082         +/-   ##
===================================================
+ Coverage   75.15947%   75.20629%   +0.04681%     
===================================================
  Files           3070        3074          +4     
  Lines         632559      632838        +279     
  Branches       46788       46797          +9     
===================================================
+ Hits          475428      475934        +506     
+ Misses        153757      153503        -254     
- Partials        3374        3401         +27     
Flag Coverage Δ
Debug 75.20629% <100.00000%> (+0.04681%) ⬆️
integration 18.03621% <ø> (+0.06725%) ⬆️
production 48.45879% <ø> (+0.07912%) ⬆️
test 97.02251% <100.00000%> (+0.00242%) ⬆️
unit 45.45832% <ø> (+0.08787%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Sep 9, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added minor comments

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 10, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Sep 10, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 9b3e300 into dotnet:main Sep 10, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 10, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripSplitStackDragDropHandler branch September 11, 2024 01:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants