Bump version of System.Runtime.CompilerServices.Unsafe to preview coming from maintenance-packages #12313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing from maintenance-packages
lonitra
reviewed
Oct 14, 2024
lonitra
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
…time.CompilerServices.Unsafe.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12313 +/- ##
===================================================
+ Coverage 75.55320% 75.55808% +0.00487%
===================================================
Files 3111 3111
Lines 635122 635122
Branches 46914 46914
===================================================
+ Hits 479855 479886 +31
+ Misses 151805 151780 -25
+ Partials 3462 3456 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Yeah, much better with the NuGet.config filtering... |
|
LGTM 👍 @carlossanlop could you resolve merge conflicts? Then we can get this merged |
lonitra
added
the
📭 waiting-author-feedback
|
Done |
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
lonitra
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have published out of the dotnet/maintenance-packages repo new preview versions of various OOB packages: https://github.com/dotnet/maintenance-packages/tree/main/src
These packages do not have any source code changes. They only have a new version number because they have a new repo of origin that uses modern arcade infrastructure (they were all residing in out-of-support branches).
Of those packages, the only one actively consumed by the dotnet/winforms repo is System.Runtime.CompilerServices.Unsafe. The new preview version now resides in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries/NuGet/Microsoft.IO.Redist/overview/6.1.0-preview.1.24511.1
The dotnet/winforms repo currently does not consume the dotnet-libraries feed, so I added it to the NuGet.config.
We don't yet have darc subscriptions. We first want to test the packages via manual dependency updates.
This is a similar PR to the one we have for dotnet/runtime dotnet/runtime#108806 and for dotnet/sdk dotnet/sdk#44121 .
Microsoft Reviewers: Open in CodeFlow