Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the test case to ensure corresponding constructor is called #12385

Merged

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Oct 25, 2024

related #10453

Proposed changes
Modified the unit tests for ToolStripStatusLabelTests.cs to ensure corresponding constructor is called

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.60575%. Comparing base (132e6e7) to head (1acd9c9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12385         +/-   ##
===================================================
- Coverage   75.60963%   75.60575%   -0.00388%     
===================================================
  Files           3140        3140                 
  Lines         636284      636277          -7     
  Branches       47049       47048          -1     
===================================================
- Hits          481092      481062         -30     
- Misses        151739      151759         +20     
- Partials        3453        3456          +3     
Flag Coverage Δ
Debug 75.60575% <100.00000%> (-0.00388%) ⬇️
integration 18.24216% <ø> (-0.00635%) ⬇️
production 49.14465% <ø> (-0.00808%) ⬇️
test 97.03042% <100.00000%> (-0.00006%) ⬇️
unit 46.10402% <ø> (-0.02811%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Oct 25, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra merged commit f2afa04 into dotnet:main Oct 25, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 25, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Oct 25, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripStatusLabel branch October 28, 2024 02:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants