Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewCellStyleConverter #12462

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Nov 12, 2024

related #10453

Proposed changes

Add unit tests for DataGridViewCellStyleConverter.cs to test its methods

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73648%. Comparing base (a3973fb) to head (a6ba0e5).
Report is 39 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12462         +/-   ##
===================================================
+ Coverage   75.71735%   75.73648%   +0.01913%     
===================================================
  Files           3152        3154          +2     
  Lines         635709      635827        +118     
  Branches       46970       46975          +5     
===================================================
+ Hits          481342      481553        +211     
+ Misses        150932      150832        -100     
- Partials        3435        3442          +7     
Flag Coverage Δ
Debug 75.73648% <100.00000%> (+0.01913%) ⬆️
integration 18.26265% <ø> (-0.00752%) ⬇️
production 49.31151% <ø> (+0.03400%) ⬆️
test 97.05124% <100.00000%> (+0.00093%) ⬆️
unit 46.29583% <ø> (+0.04113%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Nov 12, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM.

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team labels Nov 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 15, 2024
@lonitra lonitra merged commit df46341 into dotnet:main Nov 22, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Nov 22, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_DataGridViewCellStyleConverter branch December 4, 2024 01:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants