Avoids a System.InvalidCastException error to be thrown when passing ObjectCollection to AddRangeInternal of the DataGridViewComboBoxCell.ObjectCollection class
#12613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
requested review from
Tanya-Solyanik,
lonitra,
LeafShi1 and
Epica3055
ricardobossan
force-pushed
the
Issue_12612_Casting_Error_Thrown
branch
from
60e3845 to
baa8edf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12613 +/- ##
====================================================
- Coverage 75.91962% 49.78234% -26.13728%
====================================================
Files 3164 1979 -1185
Lines 636813 284155 -352658
Branches 47008 41746 -5262
====================================================
- Hits 483466 141459 -342007
+ Misses 149884 139996 -9888
+ Partials 3463 2700 -763
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardobossan
force-pushed
the
Issue_12612_Casting_Error_Thrown
branch
from
baa8edf to
b72cfc6
Compare
LeafShi1
added
the
waiting-review
.../src/System/Windows/Forms/Controls/DataGridView/DataGridViewComboBoxCell.ObjectCollection.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
waiting-author-feedback
…ObjectCollection to AddRangeInternal of the DataGridViewComboBoxCell.ObjectCollection Fixes dotnet#12612 ## Proposed changes - Avoids a `System.InvalidCastException` error to be thrown when passing `ObjectCollection` to `AddRangeInternal` of the `DataGridViewComboBoxCell.ObjectCollection` class, by: - Modifying the `AddRange(ObjectCollection value)` method - Adding the `AddRangeInternal(ObjectCollection items)` methods - Adds unit test ## Customer Impact - Avoids a possible `System.InvalidCastException` ## Regression? - No ## Risk - Minimal ## Screenshots ### Before ### After ## Test methodology - Unit tests ## Accessibility testing ## Test environment(s) - `10.0.100-alpha.1.24573.1`
ricardobossan
force-pushed
the
Issue_12612_Casting_Error_Thrown
branch
from
b72cfc6 to
7f53401
Compare
dotnet-policy-service
bot
removed
the
waiting-author-feedback
ricardobossan
added
the
waiting-review
Tanya-Solyanik
added
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
|
@ricardobossan Want to confirm with you if [WinFormsFact] is missing?
|
ricardobossan
pushed a commit
to ricardobossan/winforms
that referenced
this pull request
Dec 26, 2024
Fixes dotnet#12612 Related dotnet#12613 ## Root Cause - A `[WinFormsFact]` annotation was missing from a unit test in PR dotnet#12613, causing the test not to execute as part of the suite. ## Proposed changes - Add the missing `[WinFormsFact]` annotation to the relevant unit test. ## Customer Impact - Ensures the test runs as intended, increasing coverage and preventing regressions in the modified `DataGridViewComboBoxCell.ObjectCollection` class. ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 10.0.100-alpha.1.24573.1
|
@MelonWang1 Thanks for catching that! I've added the |
LeafShi1
pushed a commit
that referenced
this pull request
Dec 27, 2024
…12685) Fixes #12612 Related #12613 ## Root Cause - A `[WinFormsFact]` annotation was missing from a unit test in PR #12613, causing the test not to execute as part of the suite. ## Proposed changes - Add the missing `[WinFormsFact]` annotation to the relevant unit test. ## Customer Impact - Ensures the test runs as intended, increasing coverage and preventing regressions in the modified `DataGridViewComboBoxCell.ObjectCollection` class. ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 10.0.100-alpha.1.24573.1 Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12612
Proposed changes
System.InvalidCastExceptionerror to be thrown when passingObjectCollectiontoAddRangeInternalof theDataGridViewComboBoxCell.ObjectCollectionclass, by:AddRange(ObjectCollection value)methodAddRangeInternal(ObjectCollection items)methodsCustomer Impact
System.InvalidCastExceptionRegression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
10.0.100-alpha.1.24573.1Microsoft Reviewers: Open in CodeFlow