Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewCellConverter #12622

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Dec 11, 2024

related #10453

Proposed changes

Add unit tests for DataGridViewCellConverter.cs to test its methods

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03784%. Comparing base (230d349) to head (4054755).
Report is 21 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12622          +/-   ##
====================================================
+ Coverage   75.91962%   97.03784%   +21.11822%     
====================================================
  Files           3164        1183        -1981     
  Lines         636813      354572      -282241     
  Branches       47008        5410       -41598     
====================================================
- Hits          483466      344069      -139397     
+ Misses        149884        9711      -140173     
+ Partials        3463         792        -2671     
Flag Coverage Δ
Debug 97.03784% <100.00000%> (+21.11822%) ⬆️
integration ?
production ?
test 97.03784% <100.00000%> (-0.01488%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Dec 11, 2024
ricardobossan
ricardobossan previously approved these changes Dec 12, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@ricardobossan ricardobossan added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Dec 12, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed ready-to-merge PRs that are ready to merge but worth notifying the internal team. labels Dec 12, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 13, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Dec 13, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Dec 18, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 7d88751 into dotnet:main Dec 18, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Dec 18, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Dec 18, 2024
Tanya-Solyanik pushed a commit to Tanya-Solyanik/winforms that referenced this pull request Dec 19, 2024
related dotnet#10453

Add unit tests for DataGridViewCellConverter.cs to test its methods
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_DataGridViewCellConverter branch December 23, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants