Add unit tests for LinkUtilities #12647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
requested changes
Dec 17, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
I don't know why test scenarios failed, because all are passed in my local machine: |
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12647 +/- ##
====================================================
- Coverage 97.03492% 76.04299% -20.99193%
====================================================
Files 1182 3182 +2000
Lines 354561 639700 +285139
Branches 5411 47217 +41806
====================================================
+ Hits 344048 486447 +142399
- Misses 9724 149724 +140000
- Partials 789 3529 +2740
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardobossan
previously approved these changes
Dec 19, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/LinkUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Tanya-Solyanik
approved these changes
Jan 7, 2025
ricardobossan
pushed a commit
to ricardobossan/winforms
that referenced
this pull request
Jan 9, 2025
related dotnet#10453 Proposed changes Add unit tests for LinkUtilities to test its GetIELinkBehavior and EnsureLinkFonts methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Microsoft Reviewers: Open in CodeFlow