Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewRowHeightInfoPushedEventArgs #12673

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Dec 23, 2024

related #10453

Proposed changes

Add unit tests for DataGridViewRowHeightInfoPushedEventArgs.cs to test its properties

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13234%. Comparing base (dba5d6e) to head (a8a91df).
Report is 36 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12673         +/-   ##
===================================================
+ Coverage   76.03108%   76.13234%   +0.10125%     
===================================================
  Files           3181        3189          +8     
  Lines         639670      640092        +422     
  Branches       47215       47233         +18     
===================================================
+ Hits          486348      487317        +969     
+ Misses        149805      149248        -557     
- Partials        3517        3527         +10     
Flag Coverage Δ
Debug 76.13234% <100.00000%> (+0.10125%) ⬆️
integration 18.16920% <ø> (-0.00497%) ⬇️
production 50.02003% <ø> (+0.19699%) ⬆️
test 97.02888% <100.00000%> (+0.00198%) ⬆️
unit 47.25061% <ø> (+0.20524%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Dec 23, 2024
ricardobossan
ricardobossan previously approved these changes Dec 24, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 7, 2025
@Zheng-Li01 Zheng-Li01 removed the 📭 waiting-author-feedback The team requires more information from the author label Jan 8, 2025
@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jan 8, 2025
…DataGridViewRowHeightInfoPushedEventArgsTests.cs

Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
@Tanya-Solyanik Tanya-Solyanik merged commit 7c956a3 into dotnet:main Jan 8, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jan 8, 2025
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
…t#12673)

related dotnet#10453

Proposed changes
Add unit tests for DataGridViewRowHeightInfoPushedEventArgs.cs to test its properties
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_DataGridViewRowHeightInfoPushedEventArgs branch January 9, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants