-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage for DataGridViewRowHeightInfoPushedEventArgs #12673
Merged
Tanya-Solyanik
merged 2 commits into
dotnet:main
from
Zheng-Li01:Add_Code_Coverage_For_DataGridViewRowHeightInfoPushedEventArgs
Jan 8, 2025
Merged
Add code coverage for DataGridViewRowHeightInfoPushedEventArgs #12673
Tanya-Solyanik
merged 2 commits into
dotnet:main
from
Zheng-Li01:Add_Code_Coverage_For_DataGridViewRowHeightInfoPushedEventArgs
Jan 8, 2025
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12673 +/- ##
===================================================
+ Coverage 76.03108% 76.13234% +0.10125%
===================================================
Files 3181 3189 +8
Lines 639670 640092 +422
Branches 47215 47233 +18
===================================================
+ Hits 486348 487317 +969
+ Misses 149805 149248 -557
- Partials 3517 3527 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Zheng-Li01
added
the
waiting-review
This item is waiting on review by one or more members of team
label
Dec 23, 2024
ricardobossan
previously approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM!
Tanya-Solyanik
added
📭 waiting-author-feedback
The team requires more information from the author
and removed
waiting-review
This item is waiting on review by one or more members of team
labels
Jan 7, 2025
Zheng-Li01
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jan 8, 2025
Tanya-Solyanik
previously approved these changes
Jan 8, 2025
....Forms/tests/UnitTests/System/Windows/Forms/DataGridViewRowHeightInfoPushedEventArgsTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
ready-to-merge
PRs that are ready to merge but worth notifying the internal team.
label
Jan 8, 2025
…DataGridViewRowHeightInfoPushedEventArgsTests.cs Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
Zheng-Li01
dismissed stale reviews from Tanya-Solyanik and ricardobossan
via
January 8, 2025 07:09
a8a91df
Tanya-Solyanik
approved these changes
Jan 8, 2025
dotnet-policy-service
bot
removed
the
ready-to-merge
PRs that are ready to merge but worth notifying the internal team.
label
Jan 8, 2025
ricardobossan
pushed a commit
to ricardobossan/winforms
that referenced
this pull request
Jan 9, 2025
…t#12673) related dotnet#10453 Proposed changes Add unit tests for DataGridViewRowHeightInfoPushedEventArgs.cs to test its properties
Zheng-Li01
deleted the
Add_Code_Coverage_For_DataGridViewRowHeightInfoPushedEventArgs
branch
January 9, 2025 00:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Add unit tests for DataGridViewRowHeightInfoPushedEventArgs.cs to test its properties
Microsoft Reviewers: Open in CodeFlow