Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject #12707

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jan 3, 2025

related #10453

Proposed changes

  • Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject to test its DefaultAction, Name properties, State and DoDefaultAction, Navigate events
  • Enable nullability in DataGridViewTopLeftHeaderCellAccessibleObjectTests.cs.
  • Update to use the TheoryData<> pattern for theory tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.04846%. Comparing base (9007f33) to head (fbff6f8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12707         +/-   ##
===================================================
+ Coverage   76.00638%   76.04846%   +0.04208%     
===================================================
  Files           3181        3181                 
  Lines         639670      639725         +55     
  Branches       47215       47215                 
===================================================
+ Hits          486190      486501        +311     
+ Misses        149968      149714        -254     
+ Partials        3512        3510          -2     
Flag Coverage Δ
Debug 76.04846% <98.64865%> (+0.04208%) ⬆️
integration 18.17099% <ø> (+0.12508%) ⬆️
production 49.85396% <ø> (+0.08892%) ⬆️
test 97.03017% <98.64865%> (+0.00130%) ⬆️
unit 47.05028% <ø> (-0.00071%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

@Tanya-Solyanik Tanya-Solyanik merged commit cdcff18 into dotnet:main Jan 7, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 7, 2025
@Olina-Zhang Olina-Zhang deleted the UnitTest_For_DataGridViewTopLeftHeaderCellAccessibleObject branch January 7, 2025 06:40
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
…net#12707)

related dotnet#10453

Proposed changes
Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject to test its DefaultAction, Name properties, State and DoDefaultAction, Navigate events
Enable nullability in DataGridViewTopLeftHeaderCellAccessibleObjectTests.cs.
Update to use the TheoryData<> pattern for theory tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants