Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for ToolStripPanelControlCollection_XYComparer #12711

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jan 6, 2025

related #10453

Proposed changes

Add unit tests for ToolStripPanelControlCollectionXYComparer.cs to test its methods

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner January 6, 2025 02:53
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.04680%. Comparing base (dba5d6e) to head (21373c6).
Report is 28 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12711         +/-   ##
===================================================
+ Coverage   76.03108%   76.04680%   +0.01572%     
===================================================
  Files           3181        3183          +2     
  Lines         639670      639735         +65     
  Branches       47215       47216          +1     
===================================================
+ Hits          486348      486498        +150     
+ Misses        149805      149717         -88     
- Partials        3517        3520          +3     
Flag Coverage Δ
Debug 76.04680% <73.33333%> (+0.01572%) ⬆️
integration 18.17311% <ø> (-0.00105%) ⬇️
production 49.85045% <ø> (+0.02741%) ⬆️
test 97.02941% <73.33333%> (+0.00251%) ⬆️
unit 47.07489% <ø> (+0.02953%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jan 6, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM!

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jan 7, 2025
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jan 7, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit a3da2c9 into dotnet:main Jan 7, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 7, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jan 7, 2025
@ricardobossan
Copy link
Member

@Zheng-Li01 @Tanya-Solyanik A Dispose method was created, but the test class doesn't inherit from the IDisposable interface. I don't think that Dispose method is ever called. I think this needs to be added in a new PR.

@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripPanelControlCollection_XYComparer branch January 8, 2025 01:04
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
…net#12711)

related dotnet#10453

Proposed changes
Add unit tests for ToolStripPanelControlCollectionXYComparer.cs to test its methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants