Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DataGridViewTextBoxColumn #12713

Merged

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jan 6, 2025

related #10453

Proposed changes

  • Add unit tests for DataGridViewTextBoxColumn to test its Constructor, CellTemplate, MaxInputLength, SortMode properties and ToString() method
  • Enable nullability in DataGridViewTextBoxColumnTests.cs
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.12224%. Comparing base (aaac41d) to head (dc83d7c).
Report is 18 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12713         +/-   ##
===================================================
+ Coverage   76.03780%   76.12224%   +0.08444%     
===================================================
  Files           3181        3188          +7     
  Lines         639670      640060        +390     
  Branches       47215       47232         +17     
===================================================
+ Hits          486391      487228        +837     
+ Misses        149759      149302        -457     
- Partials        3520        3530         +10     
Flag Coverage Δ
Debug 76.12224% <98.57143%> (+0.08444%) ⬆️
integration 18.16753% <ø> (-0.00629%) ⬇️
production 50.00299% <ø> (+0.17046%) ⬆️
test 97.02529% <98.57143%> (-0.00612%) ⬇️
unit 47.23736% <ø> (+0.18215%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small suggestion, all LGTM!

@ricardobossan ricardobossan added the 📭 waiting-author-feedback The team requires more information from the author label Jan 7, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jan 8, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit a54a4a9 into dotnet:main Jan 8, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 8, 2025
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
related dotnet#10453

Proposed changes
Add unit tests for DataGridViewTextBoxColumn to test its Constructor, CellTemplate, MaxInputLength, SortMode properties and ToString() method
Enable nullability in DataGridViewTextBoxColumnTests.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants