Ensure ComManagedStream seekable wrapper stream has position of 0 (…
#12970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#12953) Until .NET 5, `ComManagedStream` (then `GPStream`) would wrap a non-seekable stream in a `MemoryStream` using the `MemoryStream(Byte[])` constructor. This results in a stream with a position of 0. dotnet/runtime commit 136527537e6 (Improve perfromance for loading from Stream on Windows (dotnet/corefx#31142), 2018-07-20) updated this logic to instead use `CopyTo` to populate the wrapping `MemoryStream`. This results in a stream with a non-zero position. It seems that this non-zero position causes some issues in downstream code when using `Image.FromStream` to load `.emf` and `.wmf` files, resulting in `LoadGdipImageFromStream` returning a status of 2 and thus an exception. Seek the wrapping `MemoryStream` back to the beginning after copying the source stream into it to prevent this exception. Fixes dotnet#12951
JeremyKuhne
added
🚫 * NO-MERGE *
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12970 +/- ##
=====================================================
+ Coverage 74.83821% 74.84000% +0.00178%
=====================================================
Files 3022 3022
Lines 630460 630461 +1
Branches 46797 46797
=====================================================
+ Hits 471825 471837 +12
+ Misses 155247 155235 -12
- Partials 3388 3389 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Tanya-Solyanik
approved these changes
Feb 18, 2025
JeremyKuhne
added
servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#12953)
PORTS #12953 - DO NOT SQUASH
Until .NET 5,
ComManagedStream(thenGPStream) would wrap a non-seekable stream in aMemoryStreamusing theMemoryStream(Byte[])constructor. This results in a stream with a position of 0.dotnet/runtime commit 136527537e6 (Improve perfromance for loading from Stream on Windows (dotnet/corefx#31142), 2018-07-20) updated this logic to instead use
CopyToto populate the wrappingMemoryStream. This results in a stream with a non-zero position.It seems that this non-zero position causes some issues in downstream code when using
Image.FromStreamto load.emfand.wmffiles, resulting inLoadGdipImageFromStreamreturning a status of 2 and thus an exception.Seek the wrapping
MemoryStreamback to the beginning after copying the source stream into it to prevent this exception.Microsoft Reviewers: Open in CodeFlow