Skip to content

Conversation

@Shyam-Gupta
Copy link
Member

@Shyam-Gupta Shyam-Gupta commented Oct 7, 2025

Issue: Since we made changes to LocProject.json file for WixV5 localization, the OneBuildLoc task started failing due to LocProject.json mismatch between the existing file in the repo and the generated one. The difference was in line endings.

Fix: Restoring an old version of the file which fixes the issue. Here is a successful CI build with the changes: https://dev.azure.com/dnceng/internal/_build/results?buildId=2810369&view=results

Microsoft Reviewers: Open in CodeFlow

@Shyam-Gupta Shyam-Gupta self-assigned this Oct 7, 2025
@Shyam-Gupta Shyam-Gupta requested a review from a team as a code owner October 7, 2025 21:02
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.15930%. Comparing base (749b867) to head (dc2ced9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13942         +/-   ##
===================================================
+ Coverage   77.14938%   77.15930%   +0.00992%     
===================================================
  Files           3276        3276                 
  Lines         645116      645116                 
  Branches       47705       47705                 
===================================================
+ Hits          497703      497767         +64     
+ Misses        143720      143670         -50     
+ Partials        3693        3679         -14     
Flag Coverage Δ
Debug 77.15930% <ø> (+0.00992%) ⬆️
integration 19.00960% <ø> (+0.02611%) ⬆️
production 52.03236% <ø> (+0.02223%) ⬆️
test 97.40947% <ø> (ø)
unit 49.43937% <ø> (-0.02016%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Shyam-Gupta Shyam-Gupta merged commit 31e9c89 into main Oct 7, 2025
9 checks passed
@Shyam-Gupta Shyam-Gupta deleted the release/dev/locprojectfix branch October 7, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants