Add Screen/SystemInformation tests #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughbe
force-pushed
the
screen-info-tests
branch
from
fa3dd81 to
d726c5f
Compare
RussKie
added
🚫 * NO-MERGE *
ghost
removed
the
waiting-author-feedback
RussKie
added
code cleanup
RussKie
reviewed
Aug 5, 2019
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ScreenTests.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback
hughbe
force-pushed
the
screen-info-tests
branch
from
d726c5f to
41c024a
Compare
ghost
removed
the
waiting-author-feedback
RussKie
approved these changes
Aug 5, 2019
automerge
|
Hello @RussKie! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
hughbe
force-pushed
the
screen-info-tests
branch
from
41c024a to
c12832d
Compare
This was referenced Aug 7, 2019
Merged
danmoseley
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add tests for Screen and SystemInformation and fix NRE by adding argument validation in Screen static From* methods
Customer Impact
ANE instead of NRE
Regression?
No
Risk
Could break people who catch NRE but this is unlikely and not considered breaking
Test Methodology
Unit tests included
Microsoft Reviewers: Open in CodeFlow