Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually release ITypeInfo references (missed one) #3321

Merged
merged 2 commits into from
May 22, 2020

Conversation

weltkante
Copy link
Contributor

@weltkante weltkante commented May 21, 2020

Fixes #3305
Relates to #3271

Proposed changes

Release ITypeInfo RCW manually instead of letting the GC clean up. Original PR #3315 missed one reference, this generally made the test run more stable but it was still flaky.

Customer Impact

Tests should become more stable regardless how they are run

Regression?

Yes (after merging PR #3276)

Risk

no known risk

Before

Tests start failing after PR #3276
Test were still failing occasionally after PR #3315

After

Tests should succeed even more before and after PR #3276

Test methodology

Test environment(s)

local & CI

Microsoft Reviewers: Open in CodeFlow

@weltkante weltkante requested a review from a team as a code owner May 21, 2020 10:00
@ghost ghost assigned weltkante May 21, 2020
Copy link
Contributor Author

@weltkante weltkante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it shows it was late last night, actually missed a second one outside the tests we were looking at.

Now did the smart thing and used 'Find References' command ...

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #3321 into master will increase coverage by 34.00447%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##              master       #3321          +/-   ##
====================================================
+ Coverage   64.68672%   98.69119%   +34.00447%     
====================================================
  Files           1318         430         -888     
  Lines         484206      230439      -253767     
  Branches       39910        3142       -36768     
====================================================
- Hits          313217      227423       -85794     
+ Misses        165617        2385      -163232     
+ Partials        5372         631        -4741     
Flag Coverage Δ
#Debug 98.69119% <ø> (+34.00447%) ⬆️
#production ?
#test 98.69119% <ø> (ø)

@RussKie RussKie merged commit 2e6966c into dotnet:master May 22, 2020
@ghost ghost added this to the 5.0 Preview6 milestone May 22, 2020
@RussKie RussKie added the test-bug Problem in test source code (most likely) label May 22, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken IDispatch.GetTypeInfo interop tests
2 participants