-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Text pattern to DataGridViewTextBoxCell #3866
Adding Text pattern to DataGridViewTextBoxCell #3866
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## release/5.0-rc2 #3866 +/- ##
==========================================================
+ Coverage 67.61003% 98.09908% +30.48905%
==========================================================
Files 1408 488 -920
Lines 507123 256192 -250931
Branches 41178 4321 -36857
==========================================================
- Hits 342866 251322 -91544
+ Misses 158286 4134 -154152
+ Partials 5971 736 -5235
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
43b6841
to
e2f63c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM module the feedback.
...Forms/DataGridViewTextBoxEditingControl.DataGridViewTextBoxEditingControlAccessibleObject.cs
Show resolved
Hide resolved
e2f63c8
to
ea0f3cc
Compare
Testers approved the fix ✔️
Also, this fix doesn't implement Text pattern for a DataGridViewTextBoxCell in non-edit mode (just selected). Text pattern works only when the cell in edit mode. But the main aim was achieved. |
Fixes #2786
Original Bug: 1159872
Based on PR #2701
Proposed changes
DataGridViewTextBoxEditingControlAccessibleObject
Customer Impact
Regression?
Risk
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow