Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Text pattern to DataGridViewTextBoxCell #3866

Conversation

vladimir-krestov
Copy link
Contributor

@vladimir-krestov vladimir-krestov commented Sep 9, 2020

Fixes #2786
Original Bug: 1159872
Based on PR #2701

Proposed changes

  • Enable Text pattern support for DataGridViewTextBoxEditingControlAccessibleObject

Customer Impact

  • Visually impaired users will be able to read and interact with the text content of a DataGridViewTextBoxCell

Regression?

  • No

Risk

  • Mininmal

Before

  • Narrator does not announce the text navigation and selection of a DataGridViewTextBoxCell

After

  • Narrator announces the text content of a DataGridViewTextBoxCell (navigation, selection)

Test methodology

  • Manual testing
  • CTI
  • Unit tests

Accessibility testing

  • Using Narrator and Inspect

Test environment(s)

  • .Net 5.0 Version: 5.0.0-rc.1.20431.5
  • Microsoft Windows [Version 10.0.19041.450]
Microsoft Reviewers: Open in CodeFlow

@vladimir-krestov vladimir-krestov requested a review from a team as a code owner September 9, 2020 14:25
@ghost ghost assigned vladimir-krestov Sep 9, 2020
@RussKie
Copy link
Member

RussKie commented Sep 10, 2020

/azp run

@RussKie RussKie added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Sep 10, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RussKie RussKie added this to the 5.0 RC2 milestone Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #3866 into release/5.0-rc2 will increase coverage by 30.48905%.
The diff coverage is 100.00000%.

@@                    Coverage Diff                     @@
##           release/5.0-rc2       #3866          +/-   ##
==========================================================
+ Coverage         67.61003%   98.09908%   +30.48905%     
==========================================================
  Files                 1408         488         -920     
  Lines               507123      256192      -250931     
  Branches             41178        4321       -36857     
==========================================================
- Hits                342866      251322       -91544     
+ Misses              158286        4134      -154152     
+ Partials              5971         736        -5235     
Flag Coverage Δ
#Debug 98.09908% <100.00000%> (+30.48905%) ⬆️
#production ?
#test 98.09908% <100.00000%> (-0.00763%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vladimir-krestov vladimir-krestov removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Sep 11, 2020
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@vladimir-krestov vladimir-krestov force-pushed the Isuue_2786_AddingTextPattern_to_DataGridViewEditCell branch from 43b6841 to e2f63c8 Compare September 14, 2020 06:37
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM module the feedback.

@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@vladimir-krestov vladimir-krestov force-pushed the Isuue_2786_AddingTextPattern_to_DataGridViewEditCell branch from e2f63c8 to ea0f3cc Compare September 14, 2020 20:54
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 14, 2020
@vladimir-krestov vladimir-krestov added the waiting-review This item is waiting on review by one or more members of team label Sep 16, 2020
@vladimir-krestov
Copy link
Contributor Author

Testers approved the fix ✔️
There are 2 known issues that will be fixed as a separate fix for PropertyGrid edit and ToolStripTextBox too:

Also, this fix doesn't implement Text pattern for a DataGridViewTextBoxCell in non-edit mode (just selected). Text pattern works only when the cell in edit mode.

But the main aim was achieved.

@RussKie RussKie added Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria and removed waiting-review This item is waiting on review by one or more members of team labels Sep 17, 2020
@RussKie RussKie added Servicing-approved .NET Shiproom approved the PR for merge and removed Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Sep 17, 2020
@RussKie RussKie merged commit ab849c3 into dotnet:release/5.0-rc2 Sep 18, 2020
@vladimir-krestov vladimir-krestov deleted the Isuue_2786_AddingTextPattern_to_DataGridViewEditCell branch November 4, 2020 07:36
@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGridView's edit controls don't support UIA Text pattern as required by UIA rules
2 participants