Editor Guidelines config #4836
Merged
Editor Guidelines config #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Q: how is this treating different DPI and resolutions? I see 100% and 150%. what about others? |
Nevermind, its column count. |
dreddy-work
approved these changes
Apr 23, 2021
wreuel
added a commit
to wreuel/winforms
that referenced
this pull request
Apr 28, 2021
commit ca0630b Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Wed Apr 28 23:21:46 2021 +1000 [main] Update dependencies from dotnet/runtime (dotnet#4852) * Update dependencies from https://github.com/dotnet/runtime build 20210427.1 Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , runtime.win-x64.Microsoft.NETCore.ILAsm , System.Configuration.ConfigurationManager , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.5.21226.1 -> To Version 6.0.0-preview.5.21227.1 * Update dependencies from https://github.com/dotnet/runtime build 20210427.7 Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Configuration.ConfigurationManager , runtime.win-x64.Microsoft.NETCore.ILAsm , System.CodeDom , runtime.win-x86.Microsoft.NETCore.ILAsm , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.5.21226.1 -> To Version 6.0.0-preview.5.21227.7 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> commit 9321ce6 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Tue Apr 27 20:30:13 2021 +1000 [main] Update dependencies from dotnet/runtime (dotnet#4848) commit 10b48cc Author: Stephen Toub <stoub@microsoft.com> Date: Mon Apr 26 03:53:10 2021 -0400 Add MetadataUpdateHandler to WinForms to repaint all open forms (dotnet#4831) commit 02ba694 Author: Igor Velikorossov <RussKie@users.noreply.github.com> Date: Mon Apr 26 17:34:52 2021 +1000 VS config (dotnet#4842) commit 8063e5c Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Sun Apr 25 12:33:24 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210424.4 (dotnet#4845) [main] Update dependencies from dotnet/runtime commit df5c5ae Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Sat Apr 24 12:56:20 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210424.1 (dotnet#4844) [main] Update dependencies from dotnet/runtime commit 7020d4b Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Sat Apr 24 12:55:11 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210422.1 (dotnet#4843) [main] Update dependencies from dotnet/arcade commit 973db87 Author: Igor Velikorossov <RussKie@users.noreply.github.com> Date: Sat Apr 24 15:37:13 2021 +1000 Editor Guidelines config (dotnet#4836) https://marketplace.visualstudio.com/items?itemName=PaulHarrington.EditorGuidelines commit 5ba42a1 Author: Igor Velikorossov <RussKie@users.noreply.github.com> Date: Sat Apr 24 15:36:48 2021 +1000 Script to mark API as shipped (dotnet#4837) commit 5d05007 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Fri Apr 23 12:43:12 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210422.13 (dotnet#4840) [main] Update dependencies from dotnet/runtime commit 3e70d7e Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Apr 22 12:51:23 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210422.1 (dotnet#4827) [main] Update dependencies from dotnet/runtime commit 9613a57 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Apr 22 12:45:22 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210421.1 (dotnet#4826) [main] Update dependencies from dotnet/arcade commit 90efa2b Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Apr 22 07:59:08 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210421.1 (dotnet#4823) [main] Update dependencies from dotnet/runtime commit 267a19d Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Wed Apr 21 17:33:13 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210420.2 (dotnet#4822) [main] Update dependencies from dotnet/arcade commit 76e7021 Author: Sergey Smirnov <sergey.smirnov@akvelon.com> Date: Wed Apr 21 11:34:04 2021 +0300 Fix rectangle of the ListViewGroup (dotnet#4800) Fixes dotnet#4778 ## Proposed changes - The issue with the incorrect rectangle is reproduced because the "FragmentRoot" property was not overridden. Added an override for the "FragmentRoot" property. - Fixed issue with getting a rectangle for a ListViewGroup. Now, instead of the ListViewGroup index, we use the group ID. Fixed a issue with getting an incorrect ListViewGroup index. - Added unit tests. Fixed typos in unit-tests naming <!-- We are in TELL-MODE the following section must be completed --> ## Customer Impact ### Case 1 **Before fix:**  **After fix:**  ### Case 2 **Before fix:**  **After fix:**  ## Regression? - Yes (from dotnet#3224) ## Risk - Minimal ## Test methodology <!-- How did you ensure quality? --> - CTI team - unit tests ## Accessibility testing <!-- Remove this section if PR does not change UI --> - Inspector ## Test environment(s) <!-- Remove any that don't apply --> - Microsoft Windows [Version 10.0.19041.388] - .NET Core SDK: 6.0.100-preview.2.21155.3 commit 7ecc0cf Author: Jeremy Kuhne <jkuhne@microsoft.com> Date: Tue Apr 20 19:26:13 2021 -0700 Don't use Marshal.SizeOf for SCROLLINFO (dotnet#4819) commit 29cd684 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Wed Apr 21 12:25:18 2021 +1000 [main] Update dependencies from dotnet/arcade (dotnet#4817) commit ebe1bee Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Tue Apr 20 12:51:05 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210419.10 (dotnet#4818) [main] Update dependencies from dotnet/runtime commit 248b732 Merge: 374b00e 03bd984 Author: Jeremy Kuhne <jkuhne@microsoft.com> Date: Mon Apr 19 17:03:10 2021 -0700 Merge pull request dotnet#4814 from JeremyKuhne/newgetcontext Use new GetContext overloads commit 03bd984 Author: Jeremy Kuhne <jkuhne@microsoft.com> Date: Mon Apr 19 16:00:36 2021 -0700 Use new GetContext overloads Use new Graphics.GetContext overloads that minimize allocations and remove warning suppression. commit 374b00e Merge: 3e372a1 66df1fa Author: Jeremy Kuhne <jkuhne@microsoft.com> Date: Mon Apr 19 14:58:51 2021 -0700 Merge pull request dotnet#4802 from dotnet/darc-main-81e048c2-036b-4ff2-9f48-45ff7c71cc72 [main] Update dependencies from dotnet/runtime commit 3e372a1 Merge: 7098999 a0ccc42 Author: Jeremy Kuhne <jkuhne@microsoft.com> Date: Mon Apr 19 13:41:58 2021 -0700 Merge pull request dotnet#4811 from JeremyKuhne/syslib16 Disable SYSLIB0016 warning commit a0ccc42 Author: Jeremy Kuhne <jkuhne@microsoft.com> Date: Mon Apr 19 12:57:21 2021 -0700 Disable SYSLIB0016 warning This is a new obsoletion in System.Drawing. Disabling so we can consume the new build. Will follow this change with another that consumes the newer API. commit 66df1fa Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Date: Sun Apr 18 12:07:45 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210418.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Diagnostics.EventLog , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Security.Cryptography.Cng , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.4.21214.9 -> To Version 6.0.0-preview.5.21218.1 commit 7098999 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Sat Apr 17 12:39:44 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210416.2 (dotnet#4806) [main] Update dependencies from dotnet/arcade commit b76c1b3 Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Date: Sat Apr 17 12:10:32 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210417.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.Targets , Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Diagnostics.EventLog , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Security.Cryptography.Cng , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Configuration.ConfigurationManager , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.4.21214.9 -> To Version 6.0.0-preview.5.21217.1 commit b53c2eb Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Fri Apr 16 12:40:23 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210415.5 (dotnet#4801) [main] Update dependencies from dotnet/arcade commit b1f43ab Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Date: Fri Apr 16 12:10:49 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210415.13 Microsoft.Win32.Registry , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , Microsoft.NETCore.Targets , Microsoft.NETCore.Platforms , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILDAsm , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.Drawing.Common , System.IO.FileSystem.AccessControl , System.IO.Packaging , System.IO.Pipes.AccessControl , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.AccessControl , System.Configuration.ConfigurationManager , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.Security.Cryptography.Cng , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Security.Principal.Windows , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Windows.Extensions From Version 6.0.0-preview.4.21214.9 -> To Version 6.0.0-preview.4.21215.13 commit c9287e9 Author: Devendar Reddy Adulla <dreddy@microsoft.com> Date: Thu Apr 15 19:12:24 2021 -0700 Branding change for Winforms 6.0 preview 5 (dotnet#4799) commit ecfb941 Author: Devendar Reddy Adulla <dreddy@microsoft.com> Date: Thu Apr 15 18:12:20 2021 -0700 SHipped APIs for Preview4 (dotnet#4798) commit f379253 Author: Sergey Smirnov <sergey.smirnov@akvelon.com> Date: Fri Apr 16 03:20:04 2021 +0300 Fix Empty ListViewGroups are displayed in the Inspect tree dotnet#4779 (dotnet#4789) In this issue, we have two problems with invisible ListViewGroups and invisible ListViewItems. An ListViewItem is considered invisible when it is in a ListViewGroup but not added to the ListView. In this case, the ListViewGroup contains data about it, but the ListViewItem is not displayed in the list. To solve this problem, the "GetVisibleItems" method was added, which returns a list of only displayed ListViewItems, in which the property "ListView" is not empty. Now, when receiving data about the ListViewItems of a ListViewGroup, we use this method and not "Items" property of the ListViewGroup. The second issue, if the ListViewGroup is empty or contains invisible ListViewItems (case above), then this ListViewGroup is also not displayed in the ListView. This issue was solved in the same way as the issue above, by adding the "GetVisibleGroups" method that returns a list of only the displayed ListViewGroups. Added unit tests for ListViewAccessibleObject, ListViewGroupAccessibleObject, ListViewItemAccessibleObject commit 970b01a Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Apr 15 12:51:35 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210414.9 (dotnet#4795) [main] Update dependencies from dotnet/runtime commit 2c9de98 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Thu Apr 15 12:45:45 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210414.5 (dotnet#4794) [main] Update dependencies from dotnet/arcade commit f188aa6 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Wed Apr 14 12:49:07 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210413.3 (dotnet#4792) [main] Update dependencies from dotnet/runtime commit 7e785d0 Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Wed Apr 14 00:12:18 2021 +0000 Update dependencies from https://github.com/dotnet/arcade build 20210412.6 (dotnet#4783) [main] Update dependencies from dotnet/arcade commit 7916a2c Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Tue Apr 13 12:46:42 2021 +0000 Update dependencies from https://github.com/dotnet/runtime build 20210413.1 (dotnet#4784) [main] Update dependencies from dotnet/runtime
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://marketplace.visualstudio.com/items?itemName=PaulHarrington.EditorGuidelines
Microsoft Reviewers: Open in CodeFlow