Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Win11 accessibility features in tooltips displayed by keyboard focus #5424

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Support Win11 accessibility features in tooltips displayed by keyboard focus #5424

merged 2 commits into from
Sep 15, 2021

Conversation

Tanya-Solyanik
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik commented Aug 13, 2021 •
edited
Loading

If tooltips do not set AutoPopDelay or AutomaticDelay, windows 11 assumes that they should be accessible:

  1. persistent - not dismissible by a timer but only by a user action
  2. dismissible by a keyboard (Ctrl or Esc keys)

Changes:

  1. do not start the dismissal timer for tooltips that had not set any dismissal delays
  2. Dismiss all "accessible" tooltips when any control receives Ctrl or Esc key up message
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned Tanya-Solyanik Aug 13, 2021
@ghost ghost added the draft draft PR label Sep 11, 2021
@Tanya-Solyanik Tanya-Solyanik force-pushed the tooltip-keyboard branch 5 times, most recently from 18023b1 to 3eb3112 Compare September 14, 2021 19:47
@Tanya-Solyanik Tanya-Solyanik changed the title Proof of concept that keyboard tooltip can integrate with windows 11 default timeouts Support Win11 accessibility features in tooltips displayed by keyboard focus Sep 14, 2021
@Tanya-Solyanik Tanya-Solyanik added 📖 documentation: breaking A change in behavior that could be breaking for applications. Needs to be documented. and removed draft draft PR labels Sep 14, 2021
@Tanya-Solyanik Tanya-Solyanik added the waiting-review This item is waiting on review by one or more members of team label Sep 14, 2021
@Tanya-Solyanik Tanya-Solyanik marked this pull request as ready for review September 14, 2021 21:01
@Tanya-Solyanik Tanya-Solyanik requested a review from a team as a code owner September 14, 2021 21:01
dreddy-work
dreddy-work reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Associated issue? It would be nice to see new experience. Attach a gif for before and after?

src/System.Windows.Forms/tests/UnitTests/KeyboardTooltipStateMachineTests.cs Outdated Show resolved Hide resolved
src/System.Windows.Forms/tests/UnitTests/OsVersionTests.cs Outdated Show resolved Hide resolved
dreddy-work
dreddy-work approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Tanya-Solyanik Tanya-Solyanik added the a11yMAS High Priority - Accessibility violation of Microsoft Accessibility Standards label Sep 14, 2021
@dreddy-work
Copy link
Member

Please create a PR against release/6.0 branch as well.

@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Sep 14, 2021
@Tanya-Solyanik Tanya-Solyanik merged commit 99c9e6c into dotnet:main Sep 15, 2021
@ghost ghost added this to the 7.0 alpha1 milestone Sep 15, 2021
@Tanya-Solyanik Tanya-Solyanik deleted the tooltip-keyboard branch September 15, 2021 02:07
dreddy-work added a commit that referenced this pull request Sep 15, 2021
@dreddy-work
Merge pull request #5424 from Tanya-Solyanik/tooltip-keyboard
7f8e262 
Support Win11 accessibility features in tooltips displayed by keyboard focus
# Conflicts:
#	src/System.Windows.Forms/src/System/Windows/Forms/KeyboardToolTipStateMachine.SmEvent.cs
#	src/System.Windows.Forms/src/System/Windows/Forms/KeyboardToolTipStateMachine.SmState.cs
@dreddy-work dreddy-work mentioned this pull request Sep 15, 2021
Merged
dreddy-work added a commit that referenced this pull request Sep 15, 2021
@dreddy-work
Merge pull request #5424 from Tanya-Solyanik/tooltip-keyboard (#5773)
f7daead 
Support Win11 accessibility features in tooltips displayed by keyboard focus
@Amy-Li03
Copy link
Contributor

Amy-Li03 commented Oct 28, 2021 •
edited
Loading

Verified this issue with latest build .NET SDK 7.0.100-alpha.1.21526.12, the issue is fixed. In Default AutoPopDelay value, Esc or Ctrl can dismiss controls' keyboard tooltip; In Custom AutoPopDelay value, the keyboard tooltip of controls is still keeping until timeout

@Tanya-Solyanik Tanya-Solyanik mentioned this pull request Nov 30, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie approved these changes

@dreddy-work dreddy-work dreddy-work approved these changes

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon Awaiting requested review from SergeySmirnov-Akvelon

@vladimir-krestov vladimir-krestov Awaiting requested review from vladimir-krestov

Assignees

@Tanya-Solyanik Tanya-Solyanik

Labels
a11yMAS High Priority - Accessibility violation of Microsoft Accessibility Standards 📖 documentation: breaking A change in behavior that could be breaking for applications. Needs to be documented.
Projects
None yet
Milestone
7.0 Preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@Tanya-Solyanik @dreddy-work @Amy-Li03 @RussKie