-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template to include *.user file while creating new applications. #5848
Update template to include *.user file while creating new applications. #5848
Conversation
@merriemcgaw / @Pilchie need your approval if we decide to take this to RC2 |
We actually need Tactics approval for RC2 right now. Please finish testing and fill out the servicing template, and then we can ask for approval over email. |
We will need to make this change for VB and other template types as well. |
Noticed that. validating those changes. Only CSharp though. VB did not get TFM specific templates hence were not regressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...tnet.WinForms.ProjectTemplates/content/WinFormsLibrary-CSharp/.template.config/template.json
Show resolved
Hide resolved
I don't have much context on this, so I apologize if my question is stupid. If the user creates a new Win Forms project with this .user file, I assume that this file won't get checked into source control because it's excluded by the default |
@sayedihashimi, No. We do not expect this to be added to source control. Asynch load is improved a lot in latest VS versions and we expect to see designer load issue only when creating new. All existing applications that are newly downloaded/cloned form repo may not exhibit this issue. |
@dreddy-work thanks, that's good to know. |
…s. (#5848) * Update template to include *.user file while creating new applications.
…s. (#5848) * Update template to include *.user file while creating new applications.
Fixes dotnet/winforms-designer#3724
By default *.user files are excluded/removed by the template engine. Template owners need to override this with
exclude
flag and remove the *.user files form exclusion list.Related #5547
Related #3510
Microsoft Reviewers: Open in CodeFlow