Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to include *.user file while creating new applications. #5848

Merged

Conversation

dreddy-work
Copy link
Member

@dreddy-work dreddy-work commented Sep 23, 2021

Fixes dotnet/winforms-designer#3724

By default *.user files are excluded/removed by the template engine. Template owners need to override this with exclude flag and remove the *.user files form exclusion list.

Related #5547

Related #3510

Microsoft Reviewers: Open in CodeFlow

@dreddy-work dreddy-work requested a review from a team as a code owner September 23, 2021 19:42
@ghost ghost assigned dreddy-work Sep 23, 2021
@dreddy-work
Copy link
Member Author

@merriemcgaw / @Pilchie need your approval if we decide to take this to RC2

@Pilchie
Copy link
Member

Pilchie commented Sep 23, 2021

We actually need Tactics approval for RC2 right now. Please finish testing and fill out the servicing template, and then we can ask for approval over email.

@Pilchie Pilchie added the Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria label Sep 23, 2021
@dreddy-work
Copy link
Member Author

We actually need Tactics approval for RC2 right now. Please finish testing and fill out the servicing template, and then we can ask for approval over email.

Manually verified and it works as expected. Will send out an email seeking tactics approval.
des

Pilchie
Pilchie previously approved these changes Sep 23, 2021
@KlausLoeffelmann KlausLoeffelmann changed the title Update template to include *.user file whiel creating new applications. Update template to include *.user file while creating new applications. Sep 23, 2021
@Shyam-Gupta
Copy link
Member

We will need to make this change for VB and other template types as well.

@dreddy-work
Copy link
Member Author

dreddy-work commented Sep 23, 2021

We will need to make this change for VB and other template types as well.

Noticed that. validating those changes. Only CSharp though. VB did not get TFM specific templates hence were not regressed.

@dreddy-work dreddy-work added Servicing-approved .NET Shiproom approved the PR for merge and removed Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Sep 23, 2021
Copy link
Member

@Shyam-Gupta Shyam-Gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sayedihashimi
Copy link
Member

I don't have much context on this, so I apologize if my question is stupid.

If the user creates a new Win Forms project with this .user file, I assume that this file won't get checked into source control because it's excluded by the default .gitignore file. Seems like it would break for collaborators when they get the code from SCC. Do we need to add a .gitignore in the project root to explicitly add this .user file to source control?

@dreddy-work
Copy link
Member Author

I don't have much context on this, so I apologize if my question is stupid.

If the user creates a new Win Forms project with this .user file, I assume that this file won't get checked into source control because it's excluded by the default .gitignore file. Seems like it would break for collaborators when they get the code from SCC. Do we need to add a .gitignore in the project root to explicitly add this .user file to source control?

@sayedihashimi, No. We do not expect this to be added to source control. Asynch load is improved a lot in latest VS versions and we expect to see designer load issue only when creating new. All existing applications that are newly downloaded/cloned form repo may not exhibit this issue.

@sayedihashimi
Copy link
Member

@dreddy-work thanks, that's good to know.

Shyam-Gupta pushed a commit that referenced this pull request Oct 30, 2021
…s. (#5848)

* Update template to include *.user file while creating new applications.
dreddy-work added a commit that referenced this pull request Nov 2, 2021
…s. (#5848)

* Update template to include *.user file while creating new applications.
dreddy-work added a commit that referenced this pull request Nov 9, 2021
…s. (#5848) (#6109)

* Update template to include *.user file while creating new applications.
@ghost ghost locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants