Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set runtime framework version with microsoft net core app #708

Merged
merged 7 commits into from
Apr 16, 2019

Conversation

zsd4yr
Copy link
Contributor

@zsd4yr zsd4yr commented Apr 8, 2019

No description provided.

@zsd4yr zsd4yr requested a review from a team as a code owner April 8, 2019 22:57
@ericstj
Copy link
Member

ericstj commented Apr 8, 2019

Tests are failing because you aren't acquiring this shared framework version to run on: dotnet/arcade#2343

eng/CIBuild.cmd Outdated Show resolved Hide resolved
@zsd4yr
Copy link
Contributor Author

zsd4yr commented Apr 15, 2019

still waiting on dotnet/arcade#2343

@zsd4yr zsd4yr force-pushed the dev/zadanz/runtime-framework-ver branch from baaee89 to 0c6052e Compare April 16, 2019 18:28
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #708 into master will increase coverage by 0.01617%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             master        #708         +/-   ##
==================================================
+ Coverage   27.4977%   27.51387%   +0.01617%     
==================================================
  Files          1055        1058          +3     
  Lines        291188      291195          +7     
  Branches      38518       38516          -2     
==================================================
+ Hits          80070       80119         +49     
+ Misses       207060      207019         -41     
+ Partials       4058        4057          -1
Flag Coverage Δ
#Debug 27.51387% <ø> (+0.01617%) ⬆️
#production 18.0645% <ø> (+0.00563%) ⬆️
#test 98.62685% <ø> (-0.00413%) ⬇️

@dotnet dotnet deleted a comment from codecov bot Apr 16, 2019
@zsd4yr zsd4yr merged commit a3155dc into master Apr 16, 2019
@zsd4yr zsd4yr deleted the dev/zadanz/runtime-framework-ver branch April 16, 2019 20:52
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants