Adding UIA support for WebBrowser #7314

dkazennov · 2022-06-16T14:06:21Z

Partially implements #3421
For .Net 7

Proposed changes

Updated "SupportsUiaProviders" flag to WebBrowser
Added and implemented WebBrowser.WebBrowserAccessibleObject
Added unit tests
Testing application
WebBrowserWinFormsApp.zip

Customer Impact

Screenshots

Before

ProviderDescription: "[pid:22832,providerId:0x402AA Main:Nested [pid:27400,providerId:0x402AA Main(parent link):Microsoft: MSAA Proxy (unmanaged:UIAutomationCore.dll)]; Hwnd(parent link):Microsoft: HWND Proxy (unmanaged:uiautomationcore.dll)]"

After

ProviderDescription: "[pid:25792,providerId:0x70BA2 Main:Nested [pid:30696,providerId:0x70BA2 Main(parent link):Unidentified Provider (unmanaged:coreclr.dll)]; Hwnd(parent link):Microsoft: HWND Proxy (unmanaged:uiautomationcore.dll)]"

Regression?

No

Risk

Minimal

Test methodology

Unit tests
Manual with custom application

Accessibility testing

Inspect
Accessibility Insights

Test environment

dotnet : 7.0.0-preview.4.22229.4

Microsoft Reviewers: Open in CodeFlow

RussKie · 2022-06-17T06:40:54Z

To be honest I don't think we should be spending any time updating any of WebBrowser API.

IE is officially retired and out of support as of June 15, 2022.
We're planning to deprecated all related API (see Mark WebBrowser and all related (e.g., HTML* types) as obsolete #6964).

/cc: @merriemcgaw @Tanya-Solyanik

dkazennov · 2022-06-17T07:30:19Z

Fixed tests: ControlAccessibleObject_GetPropertyValue_AccessKey_ReturnExpected
added typeof(WebBrowser) to s_controlsIgnoringTextChangesForTests (since WebBrowserBase has public override string Text property which throws exception in setter).

dkazennov · 2022-06-17T08:16:23Z

WebBrowser class implements UIA provider now. New class WebBrowserAccessibleObject passes unit tests.
Custom application works with WebBrowser control (both original and changed) as intended.
New unit tests work as intended.

I believe that everything works now. So can we keep this fix as it is already complete?

vladimir-krestov

I don't see risk of implementing this fast fix, even if IE is outdated.
The main reason - #3037. We need to provide a correct accessibility tree for implemented apps, that can use WebBrowser.
@merriemcgaw, @Tanya-Solyanik, your thoughts?

vladimir-krestov · 2022-06-17T11:32:31Z

src/System.Windows.Forms/src/System/Windows/Forms/WebBrowser.WebBrowserAccessibleObject.cs

+ internal override object? GetPropertyValue(UiaCore.UIA propertyID)
+ => propertyID switch
+ {
+ UiaCore.UIA.AutomationIdPropertyId


Please remove, it will be implemented in #7206

Please remove, it will be implemented in #7206

In #7206 it will be UiaCore.UIA.AutomationIdPropertyId => AutomationId instead. Returning Owner.Name is pre-7206.
Or should we change it pre-emptively?

If we're close I don't mind making sure apps with the WebBrowser control have the right UIA tree. But I wouldn't go spending time implementing too many patterns on this particular control.

Please remove, it will be implemented in #7206

Since #7206 is not yet implemented, I propose we don't change this method until #7206 is implemented (or if this issue is implemented first we will change WebBrowserAccessibleObject in #7206).

Just a friendly reminder to not lose this

Just a friendly reminder to not lose this

Thank you! It will be done now )

src/System.Windows.Forms/src/System/Windows/Forms/WebBrowser.WebBrowserAccessibleObject.cs

src/System.Windows.Forms/src/System/Windows/Forms/WebBrowser.cs

vladimir-krestov · 2022-06-17T11:35:30Z

src/System.Windows.Forms/src/System/Windows/Forms/WebBrowser.cs

@@ -1130,6 +1132,8 @@ protected override WebBrowserSiteBase CreateWebBrowserSiteBase()
 return new WebBrowserSite(this);
 }

+ protected override AccessibleObject CreateAccessibilityInstance() => new WebBrowserAccessibleObject(this);


UIAProvider support for WebBrowser control and UnitTests

RussKie · 2022-06-22T04:37:42Z

/azp run

azure-pipelines · 2022-06-22T04:37:54Z

Azure Pipelines successfully started running 2 pipeline(s).

RussKie

LGTM

dkazennov · 2022-06-23T08:44:33Z

CTI requested

Olina-Zhang · 2022-06-24T05:47:04Z

Tested this PR with no new issue found.

Philip-Wang01 · 2022-07-01T07:39:39Z

Verified on latest .NET core 7.0 build: .NET 7.0.100-preview.7.22330.8, issue is fixed. Screenshot as below:

Cassie-Li01 · 2022-07-22T05:44:31Z

Verified on .NET 7.0.100-preview.7.22370.3 TP build, issue is fixed, screenshot as below:

dkazennov requested a review from a team as a code owner June 16, 2022 14:06

ghost assigned dkazennov Jun 16, 2022

dkazennov added the tenet-accessibility MAS violation, UIA issue; problems with accessibility standards label Jun 16, 2022

dkazennov requested review from RussKie, Tanya-Solyanik, vladimir-krestov and dmitrii-drobotov June 16, 2022 14:08

dkazennov force-pushed the Issue_3421_WebBrowser_ShouldSupport_UIAProvider branch from 0f28ee9 to 15873a3 Compare June 16, 2022 14:46

dkazennov force-pushed the Issue_3421_WebBrowser_ShouldSupport_UIAProvider branch from 15873a3 to fc1ea12 Compare June 17, 2022 07:36

vladimir-krestov reviewed Jun 17, 2022

View reviewed changes

runfoapp bot mentioned this pull request Jun 17, 2022

Flaky System.Windows.Forms.UITests.ComboBoxTests.ComboBox_Select_Item_By_UpArrowKeyAsync #7320

Closed

Issue 3421

686642b

UIAProvider support for WebBrowser control and UnitTests

dkazennov force-pushed the Issue_3421_WebBrowser_ShouldSupport_UIAProvider branch from fc1ea12 to 686642b Compare June 20, 2022 08:53

RussKie reviewed Jun 22, 2022

View reviewed changes

dkazennov added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jun 23, 2022

Olina-Zhang removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jun 24, 2022

RussKie approved these changes Jun 28, 2022

View reviewed changes

RussKie merged commit 250c0e1 into dotnet:main Jun 28, 2022

ghost added this to the 7.0 Preview7 milestone Jun 28, 2022

dkazennov mentioned this pull request Jun 28, 2022

Refactoring AutomationId at the accessible object classes #6603 #7206

Merged

vladimir-krestov mentioned this pull request Jul 13, 2022

Epic - [Accessibility] Implement UIA provider for all controls #3421

Closed

70 tasks

dkazennov mentioned this pull request Aug 9, 2022

Fixing TabPage memory leaks #7453

Merged

ghost locked as resolved and limited conversation to collaborators Aug 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding UIA support for WebBrowser #7314

Adding UIA support for WebBrowser #7314

dkazennov commented Jun 16, 2022 •

edited by ghost

Loading

RussKie commented Jun 17, 2022

dkazennov commented Jun 17, 2022 •

edited

Loading

dkazennov commented Jun 17, 2022

vladimir-krestov left a comment

vladimir-krestov Jun 17, 2022

dkazennov Jun 20, 2022

merriemcgaw Jun 21, 2022

dkazennov Jun 22, 2022 •

edited

Loading

RussKie Jun 28, 2022

dkazennov Jun 28, 2022

vladimir-krestov Jun 17, 2022

RussKie commented Jun 22, 2022

azure-pipelines bot commented Jun 22, 2022

RussKie left a comment

dkazennov commented Jun 23, 2022

Olina-Zhang commented Jun 24, 2022

Philip-Wang01 commented Jul 1, 2022

Cassie-Li01 commented Jul 22, 2022

Adding UIA support for WebBrowser #7314

Adding UIA support for WebBrowser #7314

Conversation

dkazennov commented Jun 16, 2022 • edited by ghost Loading

Proposed changes

Customer Impact

Screenshots

Before

After

Regression?

Risk

Test methodology

Accessibility testing

Test environment

Microsoft Reviewers: Open in CodeFlow

RussKie commented Jun 17, 2022

dkazennov commented Jun 17, 2022 • edited Loading

dkazennov commented Jun 17, 2022

vladimir-krestov left a comment

Choose a reason for hiding this comment

vladimir-krestov Jun 17, 2022

Choose a reason for hiding this comment

dkazennov Jun 20, 2022

Choose a reason for hiding this comment

merriemcgaw Jun 21, 2022

Choose a reason for hiding this comment

dkazennov Jun 22, 2022 • edited Loading

Choose a reason for hiding this comment

RussKie Jun 28, 2022

Choose a reason for hiding this comment

dkazennov Jun 28, 2022

Choose a reason for hiding this comment

vladimir-krestov Jun 17, 2022

Choose a reason for hiding this comment

RussKie commented Jun 22, 2022

azure-pipelines bot commented Jun 22, 2022

RussKie left a comment

Choose a reason for hiding this comment

dkazennov commented Jun 23, 2022

Olina-Zhang commented Jun 24, 2022

Philip-Wang01 commented Jul 1, 2022

Cassie-Li01 commented Jul 22, 2022

dkazennov commented Jun 16, 2022 •

edited by ghost

Loading

dkazennov commented Jun 17, 2022 •

edited

Loading

dkazennov Jun 22, 2022 •

edited

Loading