#7320 Fixing flaky ComboBox unit test

[dkazennov]

Fixes #7320

Proposed changes

• added new stable unit test ComboBox_Select_Item_By_Key without InputSimulator.SendAsync;
• removed old integration tests ComboBox_Select_Item_By_DownArrowKeyAsync and ComboBox_Select_Item_By_UpArrowKeyAsync in UIIntegrationTests

Customer Impact

• Tests introduced in Rewrite MauiComboBoxTests #3617 #7210 are replaced with the new stable test. No flaky test issue anymore.

Regression?

• No

Risk

• Minimal

Test methodology

• Unit tests

Test environment(s)

• dotnet 7.0.0-preview.4.22229.4

Microsoft Reviewers: Open in CodeFlow

[RussKie]

Great work!

new stable unit test ComboBox_Select_Item_By_Key without InputSimulator.SendAsync;

👍

Both ways seem to work, but the new unit test seems more convenient and efficient (there is only one test with WinFormsTheory. It doesn't require the asynchronicity and doesn't generate a form). We should leave only one.

Works for me. Happy for the UI integration tests to go if we get the same test coverage.

[dkazennov]

Removed old integration tests ComboBox_Select_Item_By_DownArrowKeyAsync and ComboBox_Select_Item_By_UpArrowKeyAsync in UIIntegrationTests.

[dmitrii-drobotov]

LGTM 👍

[dmitrii-drobotov]

Now it adds numToAdd + 1 items

Suggested change

	for (int i = 0; i <= numToAdd; i++)
	for (int i = 0; i < numToAdd; i++)

[dkazennov]

We add 10 items. Then we select a first item with the index 0 and after that we simulate the down key pressure. The first item selected with the key will have the index 1. So we need one more item as a starting item.

[dkazennov]

Though comboBox.AddItems(expectedKeyPressesCount+1); would be better. Thus we will be adding the exact number of items given in the argument.

[RussKie]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).