Enable IDE0200 (remove unnecessary lambda expression) #7916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
Oct 11, 2022
| @@ -218,7 +218,7 @@ public override object EditValue(ITypeDescriptorContext context, IServiceProvide | |||
| _currentContext = context; | |||
|
|
|||
| // Child modal dialog - launching in SystemAware mode. | |||
| CollectionForm localCollectionForm = DpiHelper.CreateInstanceInSystemAwareContext(() => CreateCollectionForm()); | |||
| CollectionForm localCollectionForm = DpiHelper.CreateInstanceInSystemAwareContext(CreateCollectionForm); | |||
There was a problem hiding this comment.
IIRC, this used to have inferior perf characteristics, I have to dig for details though...
There was a problem hiding this comment.
This is no longer the case based on https://devblogs.microsoft.com/dotnet/performance_improvements_in_net_7/#analyzers
I think this was the related change dotnet/roslyn#58288
There was a problem hiding this comment.
Thank you for the link, this is what I was referring to.
RussKie
added
code cleanup
RussKie
removed
the
waiting-review
v-elnovikova
pushed a commit
to v-elnovikova/winforms
that referenced
this pull request
Oct 18, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables IDE0200 (remove unnecessary lambda expression).
Related #7887
Microsoft Reviewers: Open in CodeFlow